Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weechatScripts.weechat-matrix-bridge: don't export `olm.lua' as script #46582

Merged
merged 1 commit into from Sep 12, 2018
Merged

weechatScripts.weechat-matrix-bridge: don't export `olm.lua' as script #46582

merged 1 commit into from Sep 12, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 12, 2018 •
edited

Motivation for this change

Loading olm.lua as weechat script with `/script load olm.lua' causes
errors like this:

/nix/store/43jbh7yxh8j4gjfzbvpd9clncah5dip1-weechat-matrix-bridge-2018-05-29/lib/ffi.so: undefined symbol: lua_tointeger

As olm.lua' is loaded by matrix.lua' it doesn't need to be included
manually by the weechat configuration.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27
weechatScripts.weechat-matrix-bridge: don't export `olm.lua' as script
1c0608a 
Loading olm.lua as weechat script with `/script load olm.lua' causes
errors like this:

```
/nix/store/43jbh7yxh8j4gjfzbvpd9clncah5dip1-weechat-matrix-bridge-2018-05-29/lib/ffi.so: undefined symbol: lua_tointeger
```

As `olm.lua' is loaded by `matrix.lua' it doesn't need to be included
manually by the weechat configuration.
@xeji xeji merged commit 61a9463 into NixOS:master Sep 12, 2018
@Ma27 Ma27 deleted the fix-weechat-matrix-functionality branch September 13, 2018 06:10
vcunat pushed a commit that referenced this pull request Sep 23, 2018
@Ma27 @vcunat
weechatScripts.weechat-matrix-bridge: don't export `olm.lua' as script (
a1c48b9 
#46582)

Loading olm.lua as weechat script with `/script load olm.lua' causes
errors like this:

```
/nix/store/43jbh7yxh8j4gjfzbvpd9clncah5dip1-weechat-matrix-bridge-2018-05-29/lib/ffi.so: undefined symbol: lua_tointeger
```

As `olm.lua' is loaded by `matrix.lua' it doesn't need to be included
manually by the weechat configuration.

(cherry picked from commit 61a9463)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @GrahamcOfBorg @xeji