Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vault: 0.10.4 -> 0.11.1 #46580

Merged
merged 1 commit into from Sep 12, 2018
Merged

vault: 0.10.4 -> 0.11.1 #46580

merged 1 commit into from Sep 12, 2018

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Sep 12, 2018

Motivation for this change

upgrade!

changelog: https://github.com/hashicorp/vault/blob/v0.11.1/CHANGELOG.md

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@zimbatm zimbatm requested a review from LnL7 September 12, 2018 19:37
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: vault

Partial log (click to expand)

==> Checking that build is using go version >= 1.10...
go generate
==> Removing old directory...
==> Building...
No valid platforms to build for. If you specified a value
for the 'os', 'arch', or 'osarch' flags, make sure you're
using a valid value.
make: *** [Makefile:34: dev] Error 1
builder for '/nix/store/bf09gyd373qg9ggxbb3r7l8550rz1k7w-vault-0.11.1.drv' failed with exit code 2
error: build of '/nix/store/bf09gyd373qg9ggxbb3r7l8550rz1k7w-vault-0.11.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: vault

Partial log (click to expand)


==> Results:
total 84M
-rwxr-xr-x 1 nixbld1 nixbld 84M Sep 12 20:06 vault
installing
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/im5d9g067msilqhz8vw16gccqqs8jxi4-vault-0.11.1/bin
patching script interpreter paths in /nix/store/im5d9g067msilqhz8vw16gccqqs8jxi4-vault-0.11.1
/nix/store/im5d9g067msilqhz8vw16gccqqs8jxi4-vault-0.11.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vault

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/d4d27a2dc8f8j9qh2i57ywbzbcw4acnq-vault-0.11.1
shrinking /nix/store/d4d27a2dc8f8j9qh2i57ywbzbcw4acnq-vault-0.11.1/bin/vault
cannot find section .dynamic
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d4d27a2dc8f8j9qh2i57ywbzbcw4acnq-vault-0.11.1/bin
patching script interpreter paths in /nix/store/d4d27a2dc8f8j9qh2i57ywbzbcw4acnq-vault-0.11.1
checking for references to /build in /nix/store/d4d27a2dc8f8j9qh2i57ywbzbcw4acnq-vault-0.11.1...
cannot find section .dynamic
/nix/store/d4d27a2dc8f8j9qh2i57ywbzbcw4acnq-vault-0.11.1

@Mic92
Copy link
Member

Mic92 commented Sep 12, 2018

This version also contains a security fix, however it reads as if this would not apply to any platform we support.

@LnL7
Copy link
Member

LnL7 commented Sep 12, 2018

@GrahamcOfBorg test vault

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: tests.vault

Partial log (click to expand)

checking syntax
building '/nix/store/1j21vg6ss8kv0kh8gnn1iyzmzi5hxr19-initrd.drv'...
36335 blocks
cannot build derivation '/nix/store/2pfbca00acczb2dmqid31lyjbsjvq440-nixos-system-machine-19.03.git.0632fb1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/gjsc5c672pdv0yngk112f3594nw8b3b6-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/pyxjwfmlr57nvja2d3s0sp0ccplx5z4r-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/7ia22c6k85jsgy9x2nan9wcp5scycfc0-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/9rdi21j1mkd8xwf5fdbb9al4nk0skz48-nixos-test-driver-vault.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/pl3wp7rs8gr4k0ca17sv56icmmgp6i8z-vm-test-run-vault.drv': 1 dependencies couldn't be built
error: build of '/nix/store/pl3wp7rs8gr4k0ca17sv56icmmgp6i8z-vm-test-run-vault.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.vault

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 9.55s
cleaning up
killing machine (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/53w96ql7bcqwzypx332yxxz3c0lz70y5-vm-test-run-vault

@LnL7
Copy link
Member

LnL7 commented Sep 12, 2018

@Mic92 Regardless, there are a number of improvements and 18.09 isn't released yet so I'm going to backport it.

@LnL7 LnL7 merged commit 6e90c2e into NixOS:master Sep 12, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 13, 2018

@LnL7 fair enough.

@zimbatm zimbatm deleted the vault-0.11.1 branch September 14, 2018 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zimbatm @GrahamcOfBorg @Mic92 @LnL7