Mark broken kernel modules on Linux 4.18 #45410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Aug 21, 2018
| @@ -51,5 +51,6 @@ stdenv.mkDerivation rec { | |||
| platforms = platforms.linux; | |||
| license = licenses.gpl2Plus; | |||
| maintainers = with maintainers; [ jcumming wizeman wkennington fpletz globin ]; | |||
| broken = stdenv.lib.versionAtLeast kernel.version "4.18"; | |||
There was a problem hiding this comment.
This module will be removed eventually when zfs issues a new release, so we do have to put any effort into this one.
Mic92
reviewed
Aug 21, 2018
| @@ -33,5 +33,6 @@ stdenv.mkDerivation rec { | |||
| license = lib.licenses.gpl2; | |||
| maintainers = with lib.maintainers; [ makefu ]; | |||
| platforms = lib.platforms.linux; | |||
| broken = stdenv.lib.versionAtLeast kernel.version "4.18"; | |||
Mic92
reviewed
Aug 21, 2018
| @@ -41,5 +41,6 @@ in stdenv.mkDerivation { | |||
| platforms = [ "i686-linux" "x86_64-linux" ]; | |||
| license = licenses.gpl2; | |||
| maintainers = with maintainers; [ markuskowa ]; | |||
| broken = stdenv.lib.versionAtLeast kernel.version "4.18"; | |||
There was a problem hiding this comment.
Thanks for the heads up. I'll keep an eye on the issue.
Mic92
reviewed
Aug 21, 2018
| @@ -59,5 +59,6 @@ in stdenv.mkDerivation { | |||
| license = licenses.gpl2; | |||
| maintainers = with maintainers; [ ck3d ]; | |||
| priority = -1; | |||
| broken = stdenv.lib.versionAtLeast kernel.version "4.18"; | |||
Mic92
reviewed
Aug 21, 2018
| @@ -51,7 +51,8 @@ in stdenv.mkDerivation rec { | |||
| license = licenses.ipl10; | |||
| platforms = platforms.linux; | |||
| maintainers = [ maintainers.z77z maintainers.spacefrogg ]; | |||
| broken = versionOlder kernel.version "3.18"; | |||
| broken = versionOlder kernel.version "3.18" || | |||
| versionAtLeast kernel.version "4.18"; | |||
|
Marking those as broken, should be fine. I just wanted to make sure maintainers are notified. |
|
@Mic92 thanks for the heads-up, there is an open PR for exfat-nofuse in upstream dorimanx/exfat-nofuse#137 , i will track it and once merged i will update the package |
|
Also latest nvidia module is broken on 4.18 :) |
|
@Yardanico can you also open a pull request for that? |
9 tasks
|
aha, I didn't test any unfree software |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Not having these marked as broken makes it difficult to
nox-reviewkernel changes, since it's not clear whether modules have been broken by the change or were always broken.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)