[WIP] buildRustPackage: optionally use vendor config from cargo-vendor #45402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves a problem, where the static vendor config in pkgs/build-support/rust/default.nix would not sufficiently replace all crates Cargo is looking for. In the example of NixOS#44465, crates located at a git repo would be fetched by cargo-vendor, but not replaced in the Cargo config. Cargo then tried to access the network, resulting in build failure. Suggested-by: @symphorien
symphorien
reviewed
Aug 20, 2018
| @@ -23,9 +23,11 @@ stdenv.mkDerivation { | |||
|
|
|||
| ${cargoUpdateHook} | |||
|
|
|||
| cargo vendor | |||
| mkdir $out | |||
| cargo vendor > $out/config | |||
There was a problem hiding this comment.
this file contains the full path to ./vendor iirc which is a build impurity. So I think another sed like line 66 of pkgs/build-support/rust/default.nix is necessary to ensure this is really a fixed output derivation.
Also (nitpick) you can use the syntax cargo vendor $out/vendor > $out/config to spare a copy.
There was a problem hiding this comment.
thanks for the hints! I changed it in #45889
|
Closed in favor of #45889 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a problem, where the static vendor config in pkgs/build-support/rust/default.nix would not sufficiently replace all crates Cargo is looking for.
In the example of #44465, crates located at a git repo would be fetched by cargo-vendor, but not replaced in the Cargo config. Cargo then tried to access the network, resulting in build failure.
As this changes
fetchcargo, this would cause allcargoSha256to break, so the solution might be more difficult than that. Just wanted to implement it once.Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)