Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix on darwin note: use a <note> element #80

Merged
merged 1 commit into from Aug 21, 2018

Conversation

acowley
Copy link
Contributor

@acowley acowley commented Aug 21, 2018

This takes advantage of existing styling support.

This takes advantage of existing styling support.
@grahamc grahamc merged commit 49a4e93 into NixOS:master Aug 21, 2018
@acowley
Copy link
Contributor Author

acowley commented Aug 21, 2018

@grahamc It seems like the production CSS is different from the dev version for note elements, so this doesn’t work on the live site. I don’t know what the right approach to fixing this is given the divergence between the style files. Maybe the build instructions for this repo can be updated to produce something closer to the real site? In the meantime perhaps we should walk back these changes since they’re not going to be very helpful in their current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants