Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell lib: Add appendConfigureFlags #45408

Merged
merged 1 commit into from Aug 20, 2018
Merged

haskell lib: Add appendConfigureFlags #45408

merged 1 commit into from Aug 20, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

For consistency and completeness; other helpers have these "plural" variants too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 mentioned this pull request Aug 20, 2018
Merged
3 tasks
@Ericson2314
haskell lib: Add appendConfigureFlags
60fc04c 
For consistency and completeness; other helpers have these "plural"
variants too.
@Ericson2314 Ericson2314 merged commit 65402b0 into NixOS:master Aug 20, 2018
@Ericson2314 Ericson2314 deleted the appendConfigureFlags branch August 20, 2018 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @GrahamcOfBorg