Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-credential-gcr: remove platforms #45417

Merged
merged 1 commit into from Aug 21, 2018
Merged

docker-credential-gcr: remove platforms #45417

merged 1 commit into from Aug 21, 2018

Conversation

timbertson
Copy link
Contributor

Motivation for this change

It works fine in OSX, so let's just inherit go's supported platforms. /cc @suvash

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92

This comment has been minimized.

Sign in to view
@globin
Copy link
Member

globin commented Aug 21, 2018

@GrahamcOfBorg build docker-credential-gcr

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: docker-credential-gcr

Partial log (click to expand)

these paths will be fetched (1.21 MiB download, 4.60 MiB unpacked):
  /nix/store/jjiv98wc0izxk277cgdglzaa23ns5qrs-docker-credential-gcr-1.4.3-bin
copying path '/nix/store/jjiv98wc0izxk277cgdglzaa23ns5qrs-docker-credential-gcr-1.4.3-bin' from 'https://cache.nixos.org'...
/nix/store/jjiv98wc0izxk277cgdglzaa23ns5qrs-docker-credential-gcr-1.4.3-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: docker-credential-gcr

Partial log (click to expand)

these paths will be fetched (1.38 MiB download, 4.96 MiB unpacked):
  /nix/store/sn0bywx28fnmdxxfy4wsbx86q6vhjadg-docker-credential-gcr-1.4.3-bin
copying path '/nix/store/sn0bywx28fnmdxxfy4wsbx86q6vhjadg-docker-credential-gcr-1.4.3-bin' from 'https://cache.nixos.org'...
/nix/store/sn0bywx28fnmdxxfy4wsbx86q6vhjadg-docker-credential-gcr-1.4.3-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: docker-credential-gcr

Partial log (click to expand)

find: '/nix/store/pgv2q8pwlzvql9wqrwa3r19ygirqmn8v-docker-credential-gcr-1.4.3': No such file or directory
find: '/nix/store/pgv2q8pwlzvql9wqrwa3r19ygirqmn8v-docker-credential-gcr-1.4.3': No such file or directory
find: '/nix/store/pgv2q8pwlzvql9wqrwa3r19ygirqmn8v-docker-credential-gcr-1.4.3': No such file or directory
find: '/nix/store/pgv2q8pwlzvql9wqrwa3r19ygirqmn8v-docker-credential-gcr-1.4.3': No such file or directory
find: '/nix/store/pgv2q8pwlzvql9wqrwa3r19ygirqmn8v-docker-credential-gcr-1.4.3': No such file or directory
find: '/nix/store/pgv2q8pwlzvql9wqrwa3r19ygirqmn8v-docker-credential-gcr-1.4.3': No such file or directory
find: '/nix/store/pgv2q8pwlzvql9wqrwa3r19ygirqmn8v-docker-credential-gcr-1.4.3': No such file or directory
find: '/nix/store/pgv2q8pwlzvql9wqrwa3r19ygirqmn8v-docker-credential-gcr-1.4.3': No such file or directory
find: '/nix/store/pgv2q8pwlzvql9wqrwa3r19ygirqmn8v-docker-credential-gcr-1.4.3': No such file or directory
/nix/store/1w2bkylbxrg73j75kknyiq2wl8flqnwh-docker-credential-gcr-1.4.3-bin

@globin globin merged commit 8bb5054 into NixOS:master Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timbertson @Mic92 @globin @GrahamcOfBorg