Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/netboot: Remove redundant setting #45405

Merged
merged 1 commit into from Aug 21, 2018
Merged

nixos/netboot: Remove redundant setting #45405

merged 1 commit into from Aug 21, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

@volth tells me that is the default for system.boot.loader.kernelFile anyways.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@volth tells me that is the default for `system.boot.loader.kernelFile` anyways.
@xeji xeji merged commit d9e5447 into master Aug 21, 2018
@xeji xeji deleted the nixos-netboot-dedup branch August 21, 2018 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants