Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/dhcpcd: Wait for devices to settle, unblock nixos-unstable #45421

Merged
merged 1 commit into from Aug 21, 2018

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Aug 21, 2018

Motivation for this change

This works around #45346 and removes the channel blocker on unstable by waiting for the devices to settle via udevadm. This is needed to avoid a race condition where dhcpcd grabs the interface before predictable interface renaming is done after dhcpcd was moved to before networking.target in #44524

I still feel that it seems more logical that dhcpcd should be after networking.target (all interfaces are ready and renamed,) but since that is not desired (per the discussion in the aforementioned issue,) this should work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb srhb changed the title nixos/dhcpcd: Wait for devices to settle nixos/dhcpcd: Wait for devices to settle, unblock nixos-unstable Aug 21, 2018
@globin
Copy link
Member

globin commented Aug 21, 2018

Also see #39329 which was opened when we hat this issue with networkd.

Also maybe after = [ "systemd-udev-settle.service" ];?

@srhb srhb force-pushed the workaround-dhcpcd-before-network branch from 5f1b906 to 184d3cd Compare August 21, 2018 20:34
@srhb
Copy link
Contributor Author

srhb commented Aug 21, 2018

@globin Ah, yes, that makes sense. Thanks. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants