Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vips: Add darwin support #45420

Merged
merged 1 commit into from Aug 21, 2018
Merged

vips: Add darwin support #45420

merged 1 commit into from Aug 21, 2018

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Aug 21, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Aug 21, 2018
@adisbladis
Copy link
Member Author

@GrahamcOfBorg build vips

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vips

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5/lib  /nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5/bin
patching script interpreter paths in /nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5
/nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5/bin/shrink_width: interpreter directive changed from "/bin/sh" to "/nix/store/79b6s2wql94lwk8dyib2jc4fq8ixl13f-bash-4.4-p23/bin/sh"
/nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5/bin/batch_image_convert: interpreter directive changed from "/bin/sh" to "/nix/store/79b6s2wql94lwk8dyib2jc4fq8ixl13f-bash-4.4-p23/bin/sh"
/nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5/bin/light_correct: interpreter directive changed from "/bin/sh" to "/nix/store/79b6s2wql94lwk8dyib2jc4fq8ixl13f-bash-4.4-p23/bin/sh"
/nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5/bin/batch_rubber_sheet: interpreter directive changed from "/bin/sh" to "/nix/store/79b6s2wql94lwk8dyib2jc4fq8ixl13f-bash-4.4-p23/bin/sh"
/nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5/bin/vipsprofile: interpreter directive changed from "/usr/bin/python2" to "/nix/store/f01rhaxdfip9c49k4mhfjgfrwl5lcamn-python-2.7.15/bin/python2"
/nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5/bin/batch_crop: interpreter directive changed from "/bin/sh" to "/nix/store/79b6s2wql94lwk8dyib2jc4fq8ixl13f-bash-4.4-p23/bin/sh"
/nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5/bin/vips-8.6: interpreter directive changed from "/bin/bash" to "/nix/store/79b6s2wql94lwk8dyib2jc4fq8ixl13f-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: vips

Partial log (click to expand)

/nix/store/fsniv1s6kgp4w6mmyjg5fs0hi47v2gv4-vips-8.6.5/lib/libvips.42.dylib: fixing dylib
/nix/store/fsniv1s6kgp4w6mmyjg5fs0hi47v2gv4-vips-8.6.5/lib/libvips-cpp.42.dylib: fixing dylib
/nix/store/fsniv1s6kgp4w6mmyjg5fs0hi47v2gv4-vips-8.6.5/lib/libvipsCC.42.dylib: fixing dylib
/nix/store/fsniv1s6kgp4w6mmyjg5fs0hi47v2gv4-vips-8.6.5
/nix/store/fsniv1s6kgp4w6mmyjg5fs0hi47v2gv4-vips-8.6.5/lib/libvips.42.dylib: fixing dylib
/nix/store/fsniv1s6kgp4w6mmyjg5fs0hi47v2gv4-vips-8.6.5/lib/libvips-cpp.42.dylib: fixing dylib
/nix/store/fsniv1s6kgp4w6mmyjg5fs0hi47v2gv4-vips-8.6.5/lib/libvipsCC.42.dylib: fixing dylib
/nix/store/fsniv1s6kgp4w6mmyjg5fs0hi47v2gv4-vips-8.6.5/lib/libvips.42.dylib: fixing dylib
/nix/store/fsniv1s6kgp4w6mmyjg5fs0hi47v2gv4-vips-8.6.5/lib/libvips-cpp.42.dylib: fixing dylib
/nix/store/fsniv1s6kgp4w6mmyjg5fs0hi47v2gv4-vips-8.6.5/lib/libvipsCC.42.dylib: fixing dylib

@adisbladis adisbladis merged commit 6864680 into NixOS:master Aug 21, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: vips

Partial log (click to expand)

/nix/store/fsniv1s6kgp4w6mmyjg5fs0hi47v2gv4-vips-8.6.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vips

Partial log (click to expand)

patching script interpreter paths in /nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5
/nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5/bin/batch_rubber_sheet: interpreter directive changed from "/bin/sh" to "/nix/store/79b6s2wql94lwk8dyib2jc4fq8ixl13f-bash-4.4-p23/bin/sh"
/nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5/bin/vipsprofile: interpreter directive changed from "/usr/bin/python2" to "/nix/store/f01rhaxdfip9c49k4mhfjgfrwl5lcamn-python-2.7.15/bin/python2"
/nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5/bin/batch_crop: interpreter directive changed from "/bin/sh" to "/nix/store/79b6s2wql94lwk8dyib2jc4fq8ixl13f-bash-4.4-p23/bin/sh"
/nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5/bin/batch_image_convert: interpreter directive changed from "/bin/sh" to "/nix/store/79b6s2wql94lwk8dyib2jc4fq8ixl13f-bash-4.4-p23/bin/sh"
/nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5/bin/shrink_width: interpreter directive changed from "/bin/sh" to "/nix/store/79b6s2wql94lwk8dyib2jc4fq8ixl13f-bash-4.4-p23/bin/sh"
/nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5/bin/vips-8.6: interpreter directive changed from "/bin/bash" to "/nix/store/79b6s2wql94lwk8dyib2jc4fq8ixl13f-bash-4.4-p23/bin/bash"
/nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5/bin/light_correct: interpreter directive changed from "/bin/sh" to "/nix/store/79b6s2wql94lwk8dyib2jc4fq8ixl13f-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5...
/nix/store/05qqjrm5zcqqlh22020ly7b5h2ajphmk-vips-8.6.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: vips

Partial log (click to expand)

patching script interpreter paths in /nix/store/v8156p6n9372hd1drx1bj457wvaqzqbx-vips-8.6.5
/nix/store/v8156p6n9372hd1drx1bj457wvaqzqbx-vips-8.6.5/bin/vips-8.6: interpreter directive changed from "/bin/bash" to "/nix/store/x8npv3gr1rq1pf6gqpcdb9b68374pfd6-bash-4.4-p23/bin/bash"
/nix/store/v8156p6n9372hd1drx1bj457wvaqzqbx-vips-8.6.5/bin/vipsprofile: interpreter directive changed from "/usr/bin/python2" to "/nix/store/acbsqlqwlslqxxmihvcr2hi6rp07jfjb-python-2.7.15/bin/python2"
/nix/store/v8156p6n9372hd1drx1bj457wvaqzqbx-vips-8.6.5/bin/batch_crop: interpreter directive changed from "/bin/sh" to "/nix/store/x8npv3gr1rq1pf6gqpcdb9b68374pfd6-bash-4.4-p23/bin/sh"
/nix/store/v8156p6n9372hd1drx1bj457wvaqzqbx-vips-8.6.5/bin/batch_rubber_sheet: interpreter directive changed from "/bin/sh" to "/nix/store/x8npv3gr1rq1pf6gqpcdb9b68374pfd6-bash-4.4-p23/bin/sh"
/nix/store/v8156p6n9372hd1drx1bj457wvaqzqbx-vips-8.6.5/bin/batch_image_convert: interpreter directive changed from "/bin/sh" to "/nix/store/x8npv3gr1rq1pf6gqpcdb9b68374pfd6-bash-4.4-p23/bin/sh"
/nix/store/v8156p6n9372hd1drx1bj457wvaqzqbx-vips-8.6.5/bin/shrink_width: interpreter directive changed from "/bin/sh" to "/nix/store/x8npv3gr1rq1pf6gqpcdb9b68374pfd6-bash-4.4-p23/bin/sh"
/nix/store/v8156p6n9372hd1drx1bj457wvaqzqbx-vips-8.6.5/bin/light_correct: interpreter directive changed from "/bin/sh" to "/nix/store/x8npv3gr1rq1pf6gqpcdb9b68374pfd6-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/v8156p6n9372hd1drx1bj457wvaqzqbx-vips-8.6.5...
/nix/store/v8156p6n9372hd1drx1bj457wvaqzqbx-vips-8.6.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: vips

Partial log (click to expand)

these derivations will be built:
  /nix/store/3zn49n3lh070cyk1rjw7br7l1kk64nj7-vips-8.6.5.drv
waiting for locks or build slots...
/nix/store/v8156p6n9372hd1drx1bj457wvaqzqbx-vips-8.6.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adisbladis @GrahamcOfBorg