Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

erlang: Enable parallel building #45484

Merged
merged 1 commit into from Aug 22, 2018
Merged

erlang: Enable parallel building #45484

merged 1 commit into from Aug 22, 2018

Conversation

ejpcmac
Copy link
Contributor

@ejpcmac ejpcmac commented Aug 22, 2018

Motivation for this change

As far as I know, there are no issue in building Erlang with multiple jobs and it is faster.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented Aug 22, 2018

@GrahamcOfBorg build erlang

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: erlang

Partial log (click to expand)

/nix/store/1sbirrixr9srxi77lclykhcjy4yj2j2w-erlang-19.3.6.6/lib/erlang/bin/start_erl: interpreter directive changed from "/bin/sh" to "/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23/bin/sh"
/nix/store/1sbirrixr9srxi77lclykhcjy4yj2j2w-erlang-19.3.6.6/lib/erlang/bin/erl: interpreter directive changed from "/bin/sh" to "/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23/bin/sh"
/nix/store/1sbirrixr9srxi77lclykhcjy4yj2j2w-erlang-19.3.6.6/lib/erlang/bin/start: interpreter directive changed from "/bin/sh" to "/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23/bin/sh"
/nix/store/1sbirrixr9srxi77lclykhcjy4yj2j2w-erlang-19.3.6.6/lib/erlang/misc/makewhatis: interpreter directive changed from "/bin/sh" to "/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23/bin/sh"
/nix/store/1sbirrixr9srxi77lclykhcjy4yj2j2w-erlang-19.3.6.6/lib/erlang/misc/format_man_pages: interpreter directive changed from "/bin/sh" to "/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23/bin/sh"
/nix/store/1sbirrixr9srxi77lclykhcjy4yj2j2w-erlang-19.3.6.6/lib/erlang/Install: interpreter directive changed from "/bin/sh" to "/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/1sbirrixr9srxi77lclykhcjy4yj2j2w-erlang-19.3.6.6...
wrong ELF type
wrong ELF type
/nix/store/1sbirrixr9srxi77lclykhcjy4yj2j2w-erlang-19.3.6.6

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: erlang

Partial log (click to expand)

/nix/store/py3bqpxp01ndhz29xpdb06gsbqbn7ars-erlang-19.3.6.6/lib/erlang/bin/start: interpreter directive changed from "/bin/sh" to "/nix/store/zbhk0jhc9y8hmbcax9nvddbik3rgsary-bash-4.4-p23/bin/sh"
/nix/store/py3bqpxp01ndhz29xpdb06gsbqbn7ars-erlang-19.3.6.6/lib/erlang/bin/start_erl: interpreter directive changed from "/bin/sh" to "/nix/store/zbhk0jhc9y8hmbcax9nvddbik3rgsary-bash-4.4-p23/bin/sh"
/nix/store/py3bqpxp01ndhz29xpdb06gsbqbn7ars-erlang-19.3.6.6/lib/erlang/bin/erl: interpreter directive changed from "/bin/sh" to "/nix/store/zbhk0jhc9y8hmbcax9nvddbik3rgsary-bash-4.4-p23/bin/sh"
/nix/store/py3bqpxp01ndhz29xpdb06gsbqbn7ars-erlang-19.3.6.6/lib/erlang/lib/inets-6.3.9/priv/bin/runcgi.sh: interpreter directive changed from "/bin/sh" to "/nix/store/zbhk0jhc9y8hmbcax9nvddbik3rgsary-bash-4.4-p23/bin/sh"
/nix/store/py3bqpxp01ndhz29xpdb06gsbqbn7ars-erlang-19.3.6.6/lib/erlang/lib/inets-6.3.9/examples/server_root/cgi-bin/printenv.sh: interpreter directive changed from "/bin/sh" to "/nix/store/zbhk0jhc9y8hmbcax9nvddbik3rgsary-bash-4.4-p23/bin/sh"
/nix/store/py3bqpxp01ndhz29xpdb06gsbqbn7ars-erlang-19.3.6.6/lib/erlang/lib/mnesia-4.14.3.1/examples/bench/bench.sh: interpreter directive changed from "/bin/sh" to "/nix/store/zbhk0jhc9y8hmbcax9nvddbik3rgsary-bash-4.4-p23/bin/sh"
/nix/store/py3bqpxp01ndhz29xpdb06gsbqbn7ars-erlang-19.3.6.6/lib/erlang/lib/observer-2.3.1/priv/bin/cdv: interpreter directive changed from "/bin/sh " to "/nix/store/zbhk0jhc9y8hmbcax9nvddbik3rgsary-bash-4.4-p23/bin/sh"
/nix/store/py3bqpxp01ndhz29xpdb06gsbqbn7ars-erlang-19.3.6.6/lib/erlang/lib/observer-2.3.1/priv/bin/etop: interpreter directive changed from "/bin/sh " to "/nix/store/zbhk0jhc9y8hmbcax9nvddbik3rgsary-bash-4.4-p23/bin/sh"
/nix/store/py3bqpxp01ndhz29xpdb06gsbqbn7ars-erlang-19.3.6.6/lib/erlang/lib/edoc-0.8.1/priv/edoc_generate: interpreter directive changed from "/bin/sh" to "/nix/store/zbhk0jhc9y8hmbcax9nvddbik3rgsary-bash-4.4-p23/bin/sh"
/nix/store/py3bqpxp01ndhz29xpdb06gsbqbn7ars-erlang-19.3.6.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: erlang

Partial log (click to expand)

/nix/store/kakikvmck6qy684nnfi2gva17s91sc44-erlang-19.3.6.6/lib/erlang/Install: interpreter directive changed from "/bin/sh" to "/nix/store/9hsgp158m12qi4dsvz6x6dxy5rkiind9-bash-4.4-p23/bin/sh"
/nix/store/kakikvmck6qy684nnfi2gva17s91sc44-erlang-19.3.6.6/lib/erlang/erts-8.3.5.4/bin/start: interpreter directive changed from "/bin/sh" to "/nix/store/9hsgp158m12qi4dsvz6x6dxy5rkiind9-bash-4.4-p23/bin/sh"
/nix/store/kakikvmck6qy684nnfi2gva17s91sc44-erlang-19.3.6.6/lib/erlang/erts-8.3.5.4/bin/erl: interpreter directive changed from "/bin/sh" to "/nix/store/9hsgp158m12qi4dsvz6x6dxy5rkiind9-bash-4.4-p23/bin/sh"
/nix/store/kakikvmck6qy684nnfi2gva17s91sc44-erlang-19.3.6.6/lib/erlang/erts-8.3.5.4/bin/start_erl.src: interpreter directive changed from "/bin/sh" to "/nix/store/9hsgp158m12qi4dsvz6x6dxy5rkiind9-bash-4.4-p23/bin/sh"
/nix/store/kakikvmck6qy684nnfi2gva17s91sc44-erlang-19.3.6.6/lib/erlang/erts-8.3.5.4/bin/start.src: interpreter directive changed from "/bin/sh" to "/nix/store/9hsgp158m12qi4dsvz6x6dxy5rkiind9-bash-4.4-p23/bin/sh"
/nix/store/kakikvmck6qy684nnfi2gva17s91sc44-erlang-19.3.6.6/lib/erlang/erts-8.3.5.4/bin/erl.src: interpreter directive changed from "/bin/sh" to "/nix/store/9hsgp158m12qi4dsvz6x6dxy5rkiind9-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/kakikvmck6qy684nnfi2gva17s91sc44-erlang-19.3.6.6...
wrong ELF type
wrong ELF type
/nix/store/kakikvmck6qy684nnfi2gva17s91sc44-erlang-19.3.6.6

LnL7
LnL7 approved these changes Aug 22, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not aware of any attempts to enable this before, let's see how this does on hydra. If we notice problems can revert.

@LnL7 LnL7 merged commit 488f6a2 into NixOS:master Aug 22, 2018
@ejpcmac ejpcmac deleted the erlang-parallel-building branch August 22, 2018 23:01
@ivan ivan mentioned this pull request Dec 7, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: erlang 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ejpcmac @LnL7 @GrahamcOfBorg @Janik-Haag