Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elixir: Fix minimum OTP version #45489

Merged
merged 2 commits into from Aug 22, 2018
Merged

elixir: Fix minimum OTP version #45489

merged 2 commits into from Aug 22, 2018

Conversation

ejpcmac
Copy link
Contributor

@ejpcmac ejpcmac commented Aug 22, 2018

Motivation for this change

According to the official Elixir documentation, Elixir 1.6 and 1.7 need OTP 19 at minimum. The variable minimumOTPVersion was set to 18 for both elixir_1_6 and elixir_1_7.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

LnL7
LnL7 approved these changes Aug 22, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LnL7 LnL7 merged commit f3bf961 into NixOS:master Aug 22, 2018
@ejpcmac ejpcmac deleted the fix-elixir-minimumOTPVersion branch August 22, 2018 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: erlang 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ejpcmac @LnL7 @GrahamcOfBorg