Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pokerth: 1.1.1 -> 1.1.2, refactor, Qt 5 #46920

Merged
merged 2 commits into from Oct 20, 2018
Merged

pokerth: 1.1.1 -> 1.1.2, refactor, Qt 5 #46920

merged 2 commits into from Oct 20, 2018

Conversation

urkud
Copy link
Contributor

@urkud urkud commented Sep 20, 2018

Motivation for this change

Disclaimer: I'm not a user of pokerth, so ping @obadz. I've just picked up a random item from #33248, and updated from Qt4 to Qt5 version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

lukateras
lukateras reviewed Oct 16, 2018
View reviewed changes
Copy link
Member

@lukateras lukateras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works :-) However, pokerth derivation now builds both client and server which results in longer build time. It should be just pokerth.client instead.

@lukateras lukateras changed the title Pokerth 1.1.2 pokerth: 1.1.1 -> 1.1.2, refactor, Qt 5 Oct 19, 2018
@lukateras lukateras self-assigned this Oct 19, 2018
@lukateras
Copy link
Member

@GrahamcOfBorg build pokerth pokerth-server

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pokerth, pokerth-server

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pokerth, pokerth-server

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/1abva9afdl4p1xrkhcsyr7pjsjzp38b7-pokerth-client-1.1.2
shrinking /nix/store/1abva9afdl4p1xrkhcsyr7pjsjzp38b7-pokerth-client-1.1.2/bin/pokerth
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1abva9afdl4p1xrkhcsyr7pjsjzp38b7-pokerth-client-1.1.2/bin
patching script interpreter paths in /nix/store/1abva9afdl4p1xrkhcsyr7pjsjzp38b7-pokerth-client-1.1.2
checking for references to /build in /nix/store/1abva9afdl4p1xrkhcsyr7pjsjzp38b7-pokerth-client-1.1.2...
postPatchMkspecs
postPatchMkspecs
/nix/store/1abva9afdl4p1xrkhcsyr7pjsjzp38b7-pokerth-client-1.1.2
/nix/store/5vqcvjqyypr4935vq4xh0l47b24z2lhp-pokerth-server-1.1.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pokerth, pokerth-server

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/ghm5cdrpwagyv2fpvqdhfr1f1pp6pcbw-pokerth-client-1.1.2
shrinking /nix/store/ghm5cdrpwagyv2fpvqdhfr1f1pp6pcbw-pokerth-client-1.1.2/bin/pokerth
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ghm5cdrpwagyv2fpvqdhfr1f1pp6pcbw-pokerth-client-1.1.2/bin
patching script interpreter paths in /nix/store/ghm5cdrpwagyv2fpvqdhfr1f1pp6pcbw-pokerth-client-1.1.2
checking for references to /build in /nix/store/ghm5cdrpwagyv2fpvqdhfr1f1pp6pcbw-pokerth-client-1.1.2...
postPatchMkspecs
postPatchMkspecs
/nix/store/ghm5cdrpwagyv2fpvqdhfr1f1pp6pcbw-pokerth-client-1.1.2
/nix/store/klsjjg9dm3zfh5sp8ksi37x1nvggjnfn-pokerth-server-1.1.2

@lukateras lukateras merged commit 7731f70 into NixOS:master Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras lukateras approved these changes

Assignees

@lukateras lukateras

Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @lukateras @GrahamcOfBorg