Work in progress, will remove "WIP: " from title when ready.

Would like feedback on which of the things to check down below are relevant for a PR like this. Still wrapping my head around Nix* so I'll have to revisit those things when/if needed.

What I have done is nixos-rebuild test this branch, and it seems to run as good as the previous version. That said I haven't utilized all the guest tools features, so I can't say for sure that everything works.

Unfortunately I don't think an automated test can be written for this as nixos can't provision vmware images, but you can manually test the binary.

Ok, so, as part of trying to get automatic mounting of shared folders to work with open-vm-tools, I feel that I've tried this version update well enough to establish that things like copy/paste and manually mounting shared folders works just as well as in the previous version. I've also ran most of the binaries in the package successfully.

Unless someone else wants more testing to be done here, I'd say merge this so we get the fix that actually makes the service run at all :-)

Awesome! Glad you got this resolved.

Actually, should we cherry-pick this into 18.09 as well? If so, don't merge yet if you want it in the same PR..

Yeah I'd like to see this merged into 18.09 as well. I don't have write access so you'll have to ping someone who does.

I realise the backport is a separate PR, so this is ready for merging. Any idea when this one will be merged so I can cherry-pick? :)

Often times I jump on IRC to pester people for merging changes when I'm on a deadline. This fixes a bug and is a dead simple change so you can probably find someone to merge this for you easy enough.

@GrahamcOfBorg build open-vm-tools

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: open-vm-tools

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: open-vm-tools

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)

Attempted: open-vm-tools

/nix/store/s7ffffnpdpl3jgg5ks5q6l810wv9w3i7-open-vm-tools-10.3.0/etc/vmware-tools/poweron-vm-default: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/s7ffffnpdpl3jgg5ks5q6l810wv9w3i7-open-vm-tools-10.3.0/etc/vmware-tools/vm-support: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/s7ffffnpdpl3jgg5ks5q6l810wv9w3i7-open-vm-tools-10.3.0...
moving /nix/store/s7ffffnpdpl3jgg5ks5q6l810wv9w3i7-open-vm-tools-10.3.0/sbin/* to /nix/store/s7ffffnpdpl3jgg5ks5q6l810wv9w3i7-open-vm-tools-10.3.0/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/9s05k1l2542qghv0rdnmn6al6irfiw62-open-vm-tools-10.3.0-dev
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9s05k1l2542qghv0rdnmn6al6irfiw62-open-vm-tools-10.3.0-dev/lib
patching script interpreter paths in /nix/store/9s05k1l2542qghv0rdnmn6al6irfiw62-open-vm-tools-10.3.0-dev
checking for references to /build in /nix/store/9s05k1l2542qghv0rdnmn6al6irfiw62-open-vm-tools-10.3.0-dev...
/nix/store/s7ffffnpdpl3jgg5ks5q6l810wv9w3i7-open-vm-tools-10.3.0