Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Minor fix for python virtualenv example in nix-shell #46909

Closed
wants to merge 1 commit into from
Closed

Doc: Minor fix for python virtualenv example in nix-shell #46909

wants to merge 1 commit into from

Conversation

MelleB
Copy link

@MelleB MelleB commented Sep 19, 2018

Closes #43737

Based on suggestion mentioned in #39558 (comment)

Motivation for this change

Took me some time to fix this, hope this helps someone else.

Things done
  • Added single line to FAQ section in documentation
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

danbst added a commit to danbst/nixpkgs that referenced this pull request Feb 5, 2019
- make it easy to switch python 2/3
- add glibcLocales dep (not sure it is still required after NixOS#54485
  but manual is also used by users of Nixpkgs versions <19.03)
- use `mkShell`
- use `libffi`, as it is required for Python3 `cryptography` (in my setup it worked with Python2 without this dep)
- set PYTHONPATH. Either this or `source venv/bin/activate` was missing.

Closes NixOS#46909
@mmahut
Copy link
Member

mmahut commented Aug 9, 2019

Any updates on this pull request, please?

@jonringer
Copy link
Contributor

closing in favor of #77569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manual: "python modules using pip in a virtualenv" example don't work
4 participants