Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undervolt: 2.8 -> 2.9 #46911

Merged
merged 1 commit into from Sep 19, 2018
Merged

undervolt: 2.8 -> 2.9 #46911

merged 1 commit into from Sep 19, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 19, 2018

Looking to try this, noticed update :).

Looks fine but probably should be tested by someone.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: undervolt

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: undervolt

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: undervolt

Partial log (click to expand)

unconvert_rounded_offset (undervolt)
Doctest: undervolt.unconvert_rounded_offset ... ok
unpack_offset (undervolt)
Doctest: undervolt.unpack_offset ... ok

----------------------------------------------------------------------
Ran 5 tests in 0.010s

OK
/nix/store/b5s3l22rghzqs74y7q1s1f77gs15xw6i-undervolt-0.2.9

@eadwu
Copy link
Member

eadwu commented Sep 19, 2018 •
edited

Everything still seems to work the way it should for me.

@dtzWill dtzWill merged commit b73fa49 into NixOS:master Sep 19, 2018
@dtzWill dtzWill deleted the update/undervolt-2.9 branch September 19, 2018 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @eadwu