Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install man by default #46908

Closed
wants to merge 1 commit into from
Closed

Install man by default #46908

wants to merge 1 commit into from

Conversation

lheckemann
Copy link
Member

@lheckemann lheckemann commented Sep 19, 2018 •
edited

Motivation for this change

Manpages are useful and usually desired along with the rest of a package. In addition, there is no way to install both the manpages and the main output of a package with the imperative nix-env UI currently.

Since this only affects meta, it causes no rebuilds.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: stdenv Standard environment label Sep 19, 2018
@matthewbauer
Copy link
Member

matthewbauer commented Sep 19, 2018 •
edited

Looks like a dupe of #35884 (although that one is now out of date). I think it makes sense and less radical than my proposal in #44168.

@Ericson2314
Copy link
Member

Ericson2314 commented Sep 20, 2018 •
edited

It is a dup, and according to the dup's thread we ought to modify Nix instead :/.

@lheckemann lheckemann deleted the install-man-by-default branch September 20, 2018 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

Assignees
No one assigned
Labels
6.topic: stdenv Standard environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lheckemann @matthewbauer @Ericson2314 @GrahamcOfBorg