Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.nilearn: disable still failing tests #46918

Merged
merged 1 commit into from Sep 19, 2018
Merged

pythonPackages.nilearn: disable still failing tests #46918

merged 1 commit into from Sep 19, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 19, 2018

Motivation for this change

A previous attempt to fix two tests failing on some machines (#46850) was unsuccessful, they still failed on Hydra sometimes while succeeding locally.

Revert #46850 and disable these tests instead.

Things done
  • built in a sandbox on NixOS

@xeji
pythonPackages.nilearn: disable still failing tests
7d4af5b 
A previous attempt to fix tests failing on some machines (NixOS#46850)
was unsuccessful, they still failed on Hydra sometimes while
succeeding locally. Revert NixOS#46850 and disable these tests instead.
@xeji xeji requested a review from FRidh as a code owner September 19, 2018 21:35
@xeji
Copy link
Contributor Author

xeji commented Sep 19, 2018

@GrahamcOfBorg build python27Packages.nilearn python36Packages.nilearn

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.nilearn, python36Packages.nilearn

Partial log (click to expand)

nilearn/input_data/nifti_spheres_masker.py     116     92    21%
nilearn/masking.py                             196     39    80%
nilearn/signal.py                              169     67    60%
nilearn/version.py                              25      8    68%
----------------------------------------------------------------
TOTAL                                         4009   2445    39%
----------------------------------------------------------------------
Ran 159 tests in 6.068s

OK

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.nilearn, python36Packages.nilearn

Partial log (click to expand)

nilearn/signal.py                              169     67    60%
nilearn/version.py                              25      8    68%
----------------------------------------------------------------
TOTAL                                         4009   2445    39%
----------------------------------------------------------------------
Ran 159 tests in 7.450s

OK
/nix/store/anc6f6qinxqvjc2d73myc9drb1zawvbz-python2.7-nilearn-0.4.2
/nix/store/cfj58b4ci7dmpwpz51bvyfrf2l03ds5f-python3.6-nilearn-0.4.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.nilearn, python36Packages.nilearn

Partial log (click to expand)

nilearn/signal.py                              169     67    60%
nilearn/version.py                              25      8    68%
----------------------------------------------------------------
TOTAL                                         4009   2445    39%
----------------------------------------------------------------------
Ran 159 tests in 62.230s

OK
/nix/store/52grv3m10jp8vyyzk5kaz9fw36nlnc2l-python2.7-nilearn-0.4.2
/nix/store/s1iz6wg8x132bzx0mv4h5jcczm76nd3a-python3.6-nilearn-0.4.2

@xeji xeji merged commit f3a0c8a into NixOS:master Sep 19, 2018
xeji added a commit that referenced this pull request Sep 19, 2018
@xeji
pythonPackages.nilearn: disable still failing tests (#46918)
175d492 
A previous attempt to fix tests failing on some machines (#46850)
was unsuccessful, they still failed on Hydra sometimes while
succeeding locally. Revert #46850 and disable these tests instead.

(cherry picked from commit f3a0c8a)
@xeji xeji deleted the p/nilearn-disable-2 branch September 19, 2018 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xeji @GrahamcOfBorg