Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azcopy: init at 10.0.1 #46924

Merged
merged 1 commit into from Sep 25, 2018
Merged

azcopy: init at 10.0.1 #46924

merged 1 commit into from Sep 25, 2018

Conversation

colemickens
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@colemickens
Copy link
Member Author

(Note, in general, right now azcopy is probably taken to mean the .NET Core release, but it looks like Azure is moving to the Golang version in the future. Plus it's easier to package for now. The binary built by the repo for this package is azure-storage-azcopy, hence why I've named it such here.)

srhb
srhb reviewed Sep 20, 2018
View reviewed changes
pkgs/development/tools/azcopy/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/azcopy/default.nix Outdated Show resolved Hide resolved
@colemickens
Copy link
Member Author

Thanks for the review @srhb! I've made the requested changes.

@srhb srhb merged commit 0260747 into NixOS:master Sep 25, 2018
@colemickens colemickens deleted the azcopy branch October 19, 2018 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@colemickens @srhb @GrahamcOfBorg