Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/gdk-pixbuf: fix test on i686 #46916

Merged
merged 1 commit into from Sep 20, 2018
Merged

nixos/tests/gdk-pixbuf: fix test on i686 #46916

merged 1 commit into from Sep 20, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 19, 2018

Motivation for this change

Test VM didn't start up on i686 because it tried to create a VM with 4096M RAM but qemu-system-i386 has a hard 2047M memory limit.

  • reduce memory to 2047M on i686.
  • increase timeout 300s -> 1800s because the tests are much slower
    on i686 and timed out.

This fixes the test on my machine (but no guarantees for Hydra 馃槃).

ZHF #45960 , please backport

Things done
  • test succeeds on my local machine for i686 and x86_64-linux

cc @jtojnar

@xeji
nixos/tests/gdk-pixbuf: fix test on i686
225d454 
Test didn't run because it tried to create a VM with 4096M RAM
but qemu-system-i386 has a hard 2047M memory limit.
- reduce memory to 2047M on i686.
- increase timeout 300s -> 1800s because the tests are much slower
  on i686 and timed out.
@xeji
Copy link
Contributor Author

xeji commented Sep 19, 2018

@GrahamcOfBorg test gdk-pixbuf

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.gdk-pixbuf

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 138.35s
cleaning up
killing machine (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/v815xc8lvyh4jljbkrg0zxnx8mmgkrbr-vm-test-run-gdk-pixbuf

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.gdk-pixbuf

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 712.02s
cleaning up
killing machine (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/nn4174cwp5ykhykcvbdpaf74jay6nlys-vm-test-run-gdk-pixbuf

@xeji xeji merged commit e40d850 into NixOS:master Sep 20, 2018
xeji added a commit that referenced this pull request Sep 20, 2018
@xeji
nixos/tests/gdk-pixbuf: fix test on i686 (#46916)
af334fe 
Test didn't run because it tried to create a VM with 4096M RAM
but qemu-system-i386 has a hard 2047M memory limit.
- reduce memory to 2047M on i686.
- increase timeout 300s -> 1800s because the tests are much slower
  on i686 and timed out.

(cherry picked from commit e40d850)
@xeji xeji deleted the p/gdk-pixbuf-test branch September 20, 2018 19:30
@xeji
Copy link
Contributor Author

xeji commented Sep 20, 2018

backported: af334fe

@xeji xeji mentioned this pull request Sep 20, 2018
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xeji @GrahamcOfBorg