Removes old logo use by changing the backgrounds used #45731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wallpaper used is *structurally compatible* with the other one, meaning that the logo is at the same location, and not bigger. It has one drawback: the logo is brighter, which clashes with the grub usage. This is to be fixed with new options in grub.
The background color option is self-explanatory. The mode is either `normal` or `stretch`, they are as defined by GRUB, where normal will put the image in the top-left corner of the menu, and stretch is the default, where it stretches the image without consideration for the aspect ratio. * https://www.gnu.org/software/grub/manual/grub/grub.html#background_005fimage
This also includes a set of defaults *for this option*, where when not used, other saner defaults are used.
samueldr
force-pushed
the
artwork/older-logos-removal
branch
from
b64de66
to
01259ef
Compare
vcunat
approved these changes
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
They are the defaults used in an installed system.
Need I say more?
This also adds a set of necessary options to the grub2 module.
The PR in nixos-artwork does not strictly needs to be merged beforehand, but should be merged at the same time. This is using the GitHub feature where commit hashes of forks can be used in the source repository.
This partially addresses #11305
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)