Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vala: cleanup old versions #45741

Merged
merged 4 commits into from Aug 29, 2018
Merged

vala: cleanup old versions #45741

merged 4 commits into from Aug 29, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 29, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from jtojnar August 29, 2018 10:38
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Aug 29, 2018
@jtojnar
Copy link
Contributor

jtojnar commented Aug 29, 2018

Looks good.

I would even remove california, as it has been unmaintained for a long time, but apparently few more apps still depend on 0.34 so we might keep cali for now as well.

Though libfm can be bumped to vala. I opened an issue for font-manager and Midori apparently just reborned so they will hopefully fix it soon.

@Mic92 Mic92 merged commit a823fb3 into NixOS:master Aug 29, 2018
@Mic92 Mic92 deleted the vala-cleanup branch August 29, 2018 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @jtojnar @GrahamcOfBorg