Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atom, atom-beta: 1.29.0 -> 1.30.0, 1.30.0-beta1 -> 1.31.0-beta0 #45733

Merged
merged 1 commit into from
Aug 29, 2018
Merged

atom, atom-beta: 1.29.0 -> 1.30.0, 1.30.0-beta1 -> 1.31.0-beta0 #45733

merged 1 commit into from
Aug 29, 2018
+5 −5

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented Aug 29, 2018 •
edited
Loading

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 29, 2018
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: atom, atom-beta

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: atom, atom-beta

Partial log (click to expand)

/nix/store/vqf83dih078pk3l1c4r564r7wkkqidqh-atom-beta-1.31.0-beta0/share/atom-beta/resources/app/apm/node_modules/open/vendor/xdg-open: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/vqf83dih078pk3l1c4r564r7wkkqidqh-atom-beta-1.31.0-beta0/share/atom-beta/resources/app/apm/node_modules/ajv/scripts/prepare-tests: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/vqf83dih078pk3l1c4r564r7wkkqidqh-atom-beta-1.31.0-beta0/share/atom-beta/resources/app/apm/node_modules/ajv/scripts/travis-gh-pages: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/vqf83dih078pk3l1c4r564r7wkkqidqh-atom-beta-1.31.0-beta0/bin/.atom-beta-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/vqf83dih078pk3l1c4r564r7wkkqidqh-atom-beta-1.31.0-beta0...
cannot find section .dynamic
file /nix/store/vqf83dih078pk3l1c4r564r7wkkqidqh-atom-beta-1.31.0-beta0/share/atom-beta/atom had a PT_GNU_STACK program header, converted
file /nix/store/vqf83dih078pk3l1c4r564r7wkkqidqh-atom-beta-1.31.0-beta0/share/atom-beta/resources/app/apm/bin/node had a PT_GNU_STACK program header, converted
/nix/store/xsb3c1s94ajkrhmrkqnlak6gpcy5vpgh-atom-1.30.0
/nix/store/vqf83dih078pk3l1c4r564r7wkkqidqh-atom-beta-1.31.0-beta0

@Mic92 Mic92 merged commit 4511e70 into NixOS:master Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Synthetica9 @GrahamcOfBorg @Mic92