Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finalterm: remove non-working version #45737

Merged
merged 1 commit into from Aug 29, 2018
Merged

finalterm: remove non-working version #45737

merged 1 commit into from Aug 29, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 29, 2018

This is abandom-ware: https://worldwidemann.com/finally-terminated/
and it coredumps on startup

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji xeji merged commit e4881e2 into NixOS:master Aug 29, 2018
@Mic92 Mic92 deleted the final-removal branch August 29, 2018 09:49
@jtojnar
Copy link
Contributor

jtojnar commented Aug 29, 2018 •
edited

Yippee, we can get rid of vala_0_26. Let’s take out vanubi and vala_0_28 next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @jtojnar @GrahamcOfBorg @xeji