Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compton, compton-git: Merge derivations and update version #45729

Merged
merged 2 commits into from Aug 29, 2018
Merged

compton, compton-git: Merge derivations and update version #45729

merged 2 commits into from Aug 29, 2018

Conversation

Enzime
Copy link
Member

@Enzime Enzime commented Aug 29, 2018

Motivation for this change

Reduce code repetition to reduce likelihood that the two derivations get out of sync.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: compton, compton-git

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/rq90mh59ypjy7nxpgmyqqlx7xhjfwlhv-compton-git-2018-08-14
shrinking /nix/store/rq90mh59ypjy7nxpgmyqqlx7xhjfwlhv-compton-git-2018-08-14/bin/compton
gzipping man pages under /nix/store/rq90mh59ypjy7nxpgmyqqlx7xhjfwlhv-compton-git-2018-08-14/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rq90mh59ypjy7nxpgmyqqlx7xhjfwlhv-compton-git-2018-08-14/bin
patching script interpreter paths in /nix/store/rq90mh59ypjy7nxpgmyqqlx7xhjfwlhv-compton-git-2018-08-14
/nix/store/rq90mh59ypjy7nxpgmyqqlx7xhjfwlhv-compton-git-2018-08-14/bin/.compton-trans-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/rq90mh59ypjy7nxpgmyqqlx7xhjfwlhv-compton-git-2018-08-14...
/nix/store/pzah39882zi4yw34awn4xl54wqpcxr5y-compton-0.1_beta2.5
/nix/store/rq90mh59ypjy7nxpgmyqqlx7xhjfwlhv-compton-git-2018-08-14

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: compton, compton-git

Partial log (click to expand)

gzipping man pages under /nix/store/zm49k5m63xvdbwx1nkcs87a6cfm2srmm-compton-git-2018-08-14/share/man/
/nix/store/ifrjy5szinbs9zs4mbdk3r221dgx5n2h-compton-0.1_beta2.5/bin/.compton-trans-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zm49k5m63xvdbwx1nkcs87a6cfm2srmm-compton-git-2018-08-14/bin
checking for references to /build in /nix/store/ifrjy5szinbs9zs4mbdk3r221dgx5n2h-compton-0.1_beta2.5...
patching script interpreter paths in /nix/store/zm49k5m63xvdbwx1nkcs87a6cfm2srmm-compton-git-2018-08-14
/nix/store/zm49k5m63xvdbwx1nkcs87a6cfm2srmm-compton-git-2018-08-14/bin/.compton-trans-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/zm49k5m63xvdbwx1nkcs87a6cfm2srmm-compton-git-2018-08-14...
/nix/store/ifrjy5szinbs9zs4mbdk3r221dgx5n2h-compton-0.1_beta2.5
/nix/store/zm49k5m63xvdbwx1nkcs87a6cfm2srmm-compton-git-2018-08-14

@Mic92 Mic92 merged commit 79c7ce8 into NixOS:master Aug 29, 2018
@Enzime Enzime deleted the update/compton-git branch September 2, 2018 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Enzime @GrahamcOfBorg @Mic92