Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pywatchman: 1.3.0 -> 1.4.1 #45732

Merged
merged 2 commits into from Aug 30, 2018
Merged

pythonPackages.pywatchman: 1.3.0 -> 1.4.1 #45732

merged 2 commits into from Aug 30, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Aug 29, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner August 29, 2018 06:50
Mic92
Mic92 reviewed Aug 29, 2018
View reviewed changes
pkgs/top-level/python-packages.nix Outdated
@@ -4431,17 +4431,15 @@ in {

pywatchman = buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are moving Python expressions out of pkgs/top-level/python-packages.nix into pkgs/development/python-modules/<module>/default.nix.

Please move the expression there, and call it from pkgs/top-level/python-packages.nix using callPackage ../development/python-modules/<package> { };.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated :)

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.pywatchman python3.pkgs.pywatchman

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.pywatchman, python3.pkgs.pywatchman

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/kvvcc39frhg3kb2ryhsyiliqpknnn9li-python3.6-pywatchman-1.4.1
shrinking /nix/store/kvvcc39frhg3kb2ryhsyiliqpknnn9li-python3.6-pywatchman-1.4.1/lib/python3.6/site-packages/pywatchman/bser.cpython-36m-aarch64-linux-gnu.so
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kvvcc39frhg3kb2ryhsyiliqpknnn9li-python3.6-pywatchman-1.4.1/lib  /nix/store/kvvcc39frhg3kb2ryhsyiliqpknnn9li-python3.6-pywatchman-1.4.1/bin
patching script interpreter paths in /nix/store/kvvcc39frhg3kb2ryhsyiliqpknnn9li-python3.6-pywatchman-1.4.1
checking for references to /build in /nix/store/kvvcc39frhg3kb2ryhsyiliqpknnn9li-python3.6-pywatchman-1.4.1...
wrapping `/nix/store/kvvcc39frhg3kb2ryhsyiliqpknnn9li-python3.6-pywatchman-1.4.1/bin/watchman-make'...
wrapping `/nix/store/kvvcc39frhg3kb2ryhsyiliqpknnn9li-python3.6-pywatchman-1.4.1/bin/watchman-wait'...
/nix/store/99gsqhk8v7437bky1ls3fdshzmz87cms-python2.7-pywatchman-1.4.1
/nix/store/kvvcc39frhg3kb2ryhsyiliqpknnn9li-python3.6-pywatchman-1.4.1

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: python2.pkgs.pywatchman, python3.pkgs.pywatchman

Partial log (click to expand)

Cannot nix-instantiate `python2.pkgs.pywatchman' because:
GC Warning: Failed to expand heap by 10737418240 bytes
Can't start up: not enough memory

Cannot nix-instantiate `python3.pkgs.pywatchman' because:
GC Warning: Failed to expand heap by 10737418240 bytes
Can't start up: not enough memory

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.pywatchman, python3.pkgs.pywatchman

Partial log (click to expand)

wrapping `/nix/store/fsw6831rpgydsym0pbpli693c9y88r28-python2.7-pywatchman-1.4.1/bin/watchman-make'...
/private/tmp/nix-build-python3.6-pywatchman-1.4.1.drv-0/pywatchman-1.4.1
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/bm5j1fb0h7p17wxlsg4aa44269c72crr-python3.6-pywatchman-1.4.1/lib  /nix/store/bm5j1fb0h7p17wxlsg4aa44269c72crr-python3.6-pywatchman-1.4.1/bin
patching script interpreter paths in /nix/store/bm5j1fb0h7p17wxlsg4aa44269c72crr-python3.6-pywatchman-1.4.1
wrapping `/nix/store/bm5j1fb0h7p17wxlsg4aa44269c72crr-python3.6-pywatchman-1.4.1/bin/watchman-wait'...
wrapping `/nix/store/bm5j1fb0h7p17wxlsg4aa44269c72crr-python3.6-pywatchman-1.4.1/bin/watchman-make'...
/nix/store/fsw6831rpgydsym0pbpli693c9y88r28-python2.7-pywatchman-1.4.1
/nix/store/bm5j1fb0h7p17wxlsg4aa44269c72crr-python3.6-pywatchman-1.4.1

@FRidh FRidh merged commit ca6442b into NixOS:master Aug 30, 2018
@marsam marsam deleted the feature/update-pywatchman branch August 30, 2018 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marsam @dotlambda @GrahamcOfBorg @Mic92 @FRidh