Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boost: limit concurrent jobs to the maximum supported number #47255

Merged
merged 1 commit into from Sep 24, 2018
Merged

boost: limit concurrent jobs to the maximum supported number #47255

merged 1 commit into from Sep 24, 2018

Conversation

andrew-d
Copy link
Contributor

@andrew-d andrew-d commented Sep 23, 2018 •
edited

Motivation for this change

Versions of b2 before 1.65 have job limits; specifically:

You can see from the build failures that we appear to be running into this error

/cc ZHF #45960

(sent to staging under the assumption that this will be a huge rebuild...)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @peti @wkennington

@Mic92
Copy link
Member

Mic92 commented Sep 24, 2018

This can be merged on master right-away. <100 packages is ok.

@andrew-d andrew-d changed the base branch from staging to master September 24, 2018 00:19
@andrew-d
Copy link
Contributor Author

Ah, good to know! Just switched the base branch and force-pushed 👍

@xeji
Copy link
Contributor

xeji commented Sep 24, 2018

Let's build one each of the 3 cases
@GrahamcOfBorg build boost155 boost164 boost167

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: boost155, boost164, boost167

Partial log (click to expand)

/nix/store/pg5rpi0n4wbgwfy57av3apr48r4lz9fx-stdenv-darwin/setup: fork: retry: Resource temporarily unavailable
/nix/store/pg5rpi0n4wbgwfy57av3apr48r4lz9fx-stdenv-darwin/setup: fork: retry: Resource temporarily unavailable
/nix/store/pg5rpi0n4wbgwfy57av3apr48r4lz9fx-stdenv-darwin/setup: fork: retry: Resource temporarily unavailable
/nix/store/pg5rpi0n4wbgwfy57av3apr48r4lz9fx-stdenv-darwin/setup: fork: retry: Resource temporarily unavailable
/nix/store/pg5rpi0n4wbgwfy57av3apr48r4lz9fx-stdenv-darwin/setup: fork: retry: Resource temporarily unavailable
/nix/store/pg5rpi0n4wbgwfy57av3apr48r4lz9fx-stdenv-darwin/setup: fork: retry: Resource temporarily unavailable
/nix/store/pg5rpi0n4wbgwfy57av3apr48r4lz9fx-stdenv-darwin/setup: fork: Resource temporarily unavailable
builder for '/nix/store/7d63adbz38zm8qp49lb4m8b7n7z84fwh-boost-1.55.0.drv' failed with exit code 254
builder for '/nix/store/gg7yplard6lfwm73zwvw024y244glkls-boost-1.64.0.drv' failed with exit code 254
error: build of '/nix/store/7d63adbz38zm8qp49lb4m8b7n7z84fwh-boost-1.55.0.drv', '/nix/store/gg7yplard6lfwm73zwvw024y244glkls-boost-1.64.0.drv' failed

@xeji
Copy link
Contributor

xeji commented Sep 24, 2018

One darwin builder has had this issue since yesterday.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: boost155, boost164, boost167

Partial log (click to expand)

common.copy stage/lib/libboost_program_options.so.1.55.0
ln-UNIX stage/lib/libboost_program_options.so
...failed updating 3 targets...
...skipped 6 targets...
...updated 556 targets...
builder for '/nix/store/jbi31dss11irrbm3aln9q8q4dnwb8ha5-boost-1.55.0.drv' failed with exit code 1
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/djk3jcaya81wgcj8mizfskxn57a853h6-boost-1.64.0-dev
checking for references to /build in /nix/store/djk3jcaya81wgcj8mizfskxn57a853h6-boost-1.64.0-dev...
error: build of '/nix/store/jbi31dss11irrbm3aln9q8q4dnwb8ha5-boost-1.55.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: boost155, boost164, boost167

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/dpb90r2m88b4np5vgwcs0y9cnw6j1pss-boost-1.64.0/lib
patching script interpreter paths in /nix/store/dpb90r2m88b4np5vgwcs0y9cnw6j1pss-boost-1.64.0
checking for references to /build in /nix/store/dpb90r2m88b4np5vgwcs0y9cnw6j1pss-boost-1.64.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/2djdwhq9g8jv63yz238k3i7qc04k1b2z-boost-1.64.0-dev
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/2djdwhq9g8jv63yz238k3i7qc04k1b2z-boost-1.64.0-dev
checking for references to /build in /nix/store/2djdwhq9g8jv63yz238k3i7qc04k1b2z-boost-1.64.0-dev...
/nix/store/jg1x98kz9ihcs6cwwvyr043kykwf4ba6-boost-1.55.0
/nix/store/dpb90r2m88b4np5vgwcs0y9cnw6j1pss-boost-1.64.0
/nix/store/3l5yykp2apm5q897nhwxjxh8vfjlpvs2-boost-1.67_0

@xeji
Copy link
Contributor

xeji commented Sep 24, 2018

boost155 is broken on aarch64 ... Anyway, looks good.

@xeji xeji merged commit ba278c3 into NixOS:master Sep 24, 2018
xeji pushed a commit that referenced this pull request Sep 24, 2018
@andrew-d @xeji
boost: limit concurrent jobs to the maximum supported number (#47255)
35271fd 
(cherry picked from commit ba278c3)
@xeji
Copy link
Contributor

xeji commented Sep 24, 2018

backported: 35271fd

@andrew-d andrew-d deleted the andrew/boost-cores-limit branch September 24, 2018 16:59
@andrew-d
Copy link
Contributor Author

Thanks!

@andrew-d andrew-d mentioned this pull request Nov 10, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrew-d @Mic92 @xeji @GrahamcOfBorg