Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform-provider-gandi: init at 0.0.1 #47246

Closed
wants to merge 1 commit into from
Closed

terraform-provider-gandi: init at 0.0.1 #47246

wants to merge 1 commit into from

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Sep 23, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Sep 24, 2018

Adding this to nixpkgs/pkgs/applications/networking/cluster/terraform/providers was not possible?

@manveru
Copy link
Contributor Author

manveru commented Sep 24, 2018 via email •
edited

@matthewbauer
Copy link
Member

@GrahamcOfBorg build terraform-provider-gandi

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: terraform-provider-gandi

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wd1660dk0k9kcp7sxki805x1r90swy40-terraform-provider-gandi-0.0.1-bin
shrinking /nix/store/wd1660dk0k9kcp7sxki805x1r90swy40-terraform-provider-gandi-0.0.1-bin/bin/terraform-provider-gandi_v0.0.1
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wd1660dk0k9kcp7sxki805x1r90swy40-terraform-provider-gandi-0.0.1-bin/bin
patching script interpreter paths in /nix/store/wd1660dk0k9kcp7sxki805x1r90swy40-terraform-provider-gandi-0.0.1-bin
checking for references to /build in /nix/store/wd1660dk0k9kcp7sxki805x1r90swy40-terraform-provider-gandi-0.0.1-bin...
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
/nix/store/wd1660dk0k9kcp7sxki805x1r90swy40-terraform-provider-gandi-0.0.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: terraform-provider-gandi

Partial log (click to expand)

find: '/nix/store/6knglmr2ymw6nk4538ydziqsnvf5z72s-terraform-provider-gandi-0.0.1': No such file or directory
find: '/nix/store/6knglmr2ymw6nk4538ydziqsnvf5z72s-terraform-provider-gandi-0.0.1': No such file or directory
find: '/nix/store/6knglmr2ymw6nk4538ydziqsnvf5z72s-terraform-provider-gandi-0.0.1': No such file or directory
find: '/nix/store/6knglmr2ymw6nk4538ydziqsnvf5z72s-terraform-provider-gandi-0.0.1': No such file or directory
find: '/nix/store/6knglmr2ymw6nk4538ydziqsnvf5z72s-terraform-provider-gandi-0.0.1': No such file or directory
find: '/nix/store/6knglmr2ymw6nk4538ydziqsnvf5z72s-terraform-provider-gandi-0.0.1': No such file or directory
find: '/nix/store/6knglmr2ymw6nk4538ydziqsnvf5z72s-terraform-provider-gandi-0.0.1': No such file or directory
find: '/nix/store/6knglmr2ymw6nk4538ydziqsnvf5z72s-terraform-provider-gandi-0.0.1': No such file or directory
find: '/nix/store/6knglmr2ymw6nk4538ydziqsnvf5z72s-terraform-provider-gandi-0.0.1': No such file or directory
/nix/store/63kychvj95kr8ccs5bpkhc56igsw5p2p-terraform-provider-gandi-0.0.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: terraform-provider-gandi

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/aas0193zhj6j417b4m9rd83ss3lk5p2c-terraform-provider-gandi-0.0.1-bin
shrinking /nix/store/aas0193zhj6j417b4m9rd83ss3lk5p2c-terraform-provider-gandi-0.0.1-bin/bin/terraform-provider-gandi_v0.0.1
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/aas0193zhj6j417b4m9rd83ss3lk5p2c-terraform-provider-gandi-0.0.1-bin/bin
patching script interpreter paths in /nix/store/aas0193zhj6j417b4m9rd83ss3lk5p2c-terraform-provider-gandi-0.0.1-bin
/nix/store/aas0193zhj6j417b4m9rd83ss3lk5p2c-terraform-provider-gandi-0.0.1-bin
checking for references to /build in /nix/store/aas0193zhj6j417b4m9rd83ss3lk5p2c-terraform-provider-gandi-0.0.1-bin...
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip

@Mic92
Copy link
Member

Mic92 commented Sep 30, 2018

We have now moved all terraform plugins into terraformPlugins: #47407

@Mic92
Copy link
Member

Mic92 commented Sep 30, 2018

It should be now possible to also move this one there.

@manveru
Copy link
Contributor Author

manveru commented Oct 1, 2018 •
edited

@Mic92 i checked, but since their repo has no tags (or releases) it doesn't fit in with the others. I made an issue there so they'll hopefully add a tag, but until then I'll just resolve the conflict and call it a day.

go-gandi/terraform-provider-gandi#7

kalbasit
kalbasit requested changes Oct 2, 2018
View reviewed changes
pkgs/applications/networking/cluster/terraform-provider-gandi/default.nix
license = licenses.mpl20;
maintainers = with maintainers; [ manveru ];
};
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move this entire package to pkgs/applications/networking/cluster/terraform-providers/gandi. (make sure to rebase over current master).

@tiramiseb
Copy link
Contributor

Hi ! I'm the author of terraform-provider-gandi. I'm familiar with Nix packages needs, I have created some Nix packages myself ;)
FYI, I will make a release very soon. It will be version 1.0.0.

@kalbasit
Copy link
Member

kalbasit commented Oct 2, 2018

oh cool! @manveru maybe wait until the release is out? FYI the update-all script does not support deps so you might have to introduce overrides so you can add the dependencies there.

@tiramiseb
Copy link
Contributor

v1.0.0 has been released!

@zimbatm
Copy link
Member

zimbatm commented Oct 4, 2018

hey @manveru, we recently refactored how plugins are being stored

see pkgs/applications/networking/cluster/terraform-providers. It now includes both official and unofficial plugins.

@flokli
Copy link
Contributor

flokli commented Oct 11, 2018

Also looking very much forward to use this provider :-)

@zimbatm zimbatm mentioned this pull request Oct 11, 2018
Merged
9 tasks
@zimbatm
Copy link
Member

zimbatm commented Oct 11, 2018

I had to rebase the branch, replacing this PR by #48223

@zimbatm zimbatm closed this Oct 11, 2018
@manveru manveru deleted the terraform-provider-gandi branch November 29, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit requested changes

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@manveru @Mic92 @matthewbauer @GrahamcOfBorg @tiramiseb @kalbasit @zimbatm @flokli