Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim: remove legacy additional-nix-code #47221

Merged
merged 1 commit into from Sep 24, 2018
Merged

vim: remove legacy additional-nix-code #47221

merged 1 commit into from Sep 24, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 23, 2018

This is a left-over from #46394
We no longer use this.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
vim: remove legacy additional-nix-code
aa39d5a 
This is a left-over from NixOS#46394
We no longer use this.
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: vim

Partial log (click to expand)

these paths will be fetched (6.54 MiB download, 30.83 MiB unpacked):
  /nix/store/7sc08spk19302mssrna1wqdinikawa46-vim-8.1.0348
copying path '/nix/store/7sc08spk19302mssrna1wqdinikawa46-vim-8.1.0348' from 'https://cache.nixos.org'...
/nix/store/7sc08spk19302mssrna1wqdinikawa46-vim-8.1.0348

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vim

Partial log (click to expand)

these paths will be fetched (6.48 MiB download, 30.72 MiB unpacked):
  /nix/store/f5gh446d04q1qf8vpwqr7hs18wxb11ig-vim-8.1.0348
copying path '/nix/store/f5gh446d04q1qf8vpwqr7hs18wxb11ig-vim-8.1.0348' from 'https://cache.nixos.org'...
/nix/store/f5gh446d04q1qf8vpwqr7hs18wxb11ig-vim-8.1.0348

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: vim

Partial log (click to expand)

these paths will be fetched (6.73 MiB download, 33.65 MiB unpacked):
  /nix/store/b2s98k8rrhiivrk27wp9v535cm4sba4i-vim-8.1.0348
  /nix/store/vlanzrrh4c1isxqknq93lypwr62pj14m-ncurses-6.1
copying path '/nix/store/vlanzrrh4c1isxqknq93lypwr62pj14m-ncurses-6.1' from 'https://cache.nixos.org'...
copying path '/nix/store/b2s98k8rrhiivrk27wp9v535cm4sba4i-vim-8.1.0348' from 'https://cache.nixos.org'...
/nix/store/b2s98k8rrhiivrk27wp9v535cm4sba4i-vim-8.1.0348

@Mic92
Copy link
Member Author

Mic92 commented Sep 23, 2018

mhm because of the rebuild this might be still actually used somewhere.

@Mic92
Copy link
Member Author

Mic92 commented Sep 23, 2018

Should we completely remove nix2vim?

@Mic92 Mic92 requested a review from LnL7 September 23, 2018 14:41
@Mic92 Mic92 merged commit 82e739a into NixOS:master Sep 24, 2018
@Mic92 Mic92 deleted the vim-additional-nix-code branch September 24, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @GrahamcOfBorg @LnL7