tig: fix zsh completion #47234
Merged
tig: fix zsh completion #47234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ZSH completion script of `tig` basically imports the bash completion script and uses it as completion approach. Unfortunately the script takes several assumptions about the directory structure using `$funcsourcetrace`[1] that don't apply on NixOS. The easiest workaround is t opatch the completion script and import the bash completion script from `$out`. [1] http://zsh.sourceforge.net/Doc/Release/Zsh-Modules.html#index-funcsourcetrace
|
Success on aarch64-linux (full log) Attempted: tig Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: tig Partial log (click to expand)
|
|
Do you know why I have to explicitly source this file also it is in my fpath? If I do: It works. |
|
It was still in my global fpath. |
|
backport: 19e8f7c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The ZSH completion script of
tigbasically imports the bash completionscript and uses it as completion approach. Unfortunately the script
takes several assumptions about the directory structure using
$funcsourcetrace[1] that don't apply on NixOS.The easiest workaround is t opatch the completion script and import the
bash completion script from
$out.[1] http://zsh.sourceforge.net/Doc/Release/Zsh-Modules.html#index-funcsourcetrace
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)