hdf4: fix build on aarch64-linux #47209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build hdf4 |
|
Success on x86_64-linux (full log) Attempted: hdf4 Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: hdf4 Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: hdf4 Partial log (click to expand)
|
xeji
reviewed
Sep 23, 2018
pkgs/tools/misc/hdf4/default.nix
Outdated
| let | ||
| debianPatches = fetchurl { | ||
| # NOTE: debian hasn't packaged 4.2.14 just yet, but these patches apply cleanly. | ||
| url = "mirror://debian/pool/main/libh/libhdf4/libhdf4_4.2.13-4.debian.tar.xz"; |
There was a problem hiding this comment.
These debian source URLs are not stable. They're not under version control and may be removed when Debian releases a new patch level (for instance, 4.2.13-3 doesn't exist anymore, only 4.2.13-4), leading to 404s in our builds ...
Please fetchpatch the patches from the Debian gitlab repo https://salsa.debian.org/debian-gis-team/hdf4/tree/4e4e3f543e325911533b8617e2eb4082987f9fe2/debian/patches instead. These are pinned to a git revision and don't change or disappear.
There was a problem hiding this comment.
Oh, good to know! I switched to individual fetchpatches for those patches, since I didn't want to clone the whole git repo in order to fetch 4 files 馃槂
There was a problem hiding this comment.
(and yes , fetchpatch ing each patch individually is the standard way to do it 馃憤 ).
Pull in the Debian patches for AArch64 support, and a bonus patch for reproducible builds while we're at it.
andrew-d
force-pushed
the
andrew/hdf4-aarch64
branch
from
511af78
to
e8f0411
Compare
|
@GrahamcOfBorg build hdf4 |
|
Unexpected error: command failed with exit code 1 on x86_64-darwin (full log) Attempted: hdf4 Partial log (click to expand)
|
|
darwin: looks like a transient builder issue. |
|
Success on x86_64-linux (full log) Attempted: hdf4 Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: hdf4 Partial log (click to expand)
|
|
Try again for darwin: |
|
Unexpected error: command failed with exit code 1 on x86_64-darwin (full log) Attempted: hdf4 Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: hdf4 Partial log (click to expand)
|
|
(unfortunately we cannot tell ofborg to only build a package for one platform yet) |
|
OK, let's ignore darwin for now, looks like the builder is out of resources. Thank you for fixing this! |
xeji
pushed a commit
that referenced
this pull request
Sep 23, 2018
Pull in the Debian patches for AArch64 support, and a bonus patch for reproducible builds while we're at it. (cherry picked from commit 104014c)
|
backported: 18a7c1d |
|
Success on aarch64-linux (full log) Attempted: hdf4 Partial log (click to expand)
|
|
@xeji - And thank you for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Pull in the Debian patches for AArch64 support, and a bonus patch for reproducible builds while we're at it.
I don't have an AArch64 host to test on, so I'd appreciate someone poking @GrahamcOfBorg for me 馃槂 I think this should work, though, according to the failures in the build log.
/cc ZHF #45960
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)cc @knedlsepp