Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyftgl: fix build #47232

Merged
merged 1 commit into from Sep 23, 2018
Merged

pythonPackages.pyftgl: fix build #47232

merged 1 commit into from Sep 23, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 23, 2018 •
edited

Motivation for this change

See https://hydra.nixos.org/build/80705583

Recent boost versions with python enabled have changed their naming
scheme for boost_python shared objects which causes issues with the
proper linking when building pyftgl.

Previously the library was named boost_python3, no it's named
boost_python36 for current python (3.6.x).

Addresses #45960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 requested a review from FRidh as a code owner September 23, 2018 16:52
@Ma27 Ma27 changed the title python3Packages.pyftgl: fix build WIP python3Packages.pyftgl: fix build Sep 23, 2018
@Ma27
Copy link
Member Author

Ma27 commented Sep 23, 2018

the issue applies for python27 as well, setting to WIP until this is fixed

@Ma27
pythonPackages.pyftgl: fix build
8b65cb4 
See https://hydra.nixos.org/build/80705583

Recent `boost` versions with `python` enabled have changed their naming
scheme for `boost_python` shared objects which causes issues with the
proper linking when building `pyftgl`.

Previously the library was named `boost_python3`, no it's named
`boost_python36` for current python (3.6.x).

The same issue applies for the `python2`.

Addresses NixOS#45960
@Ma27 Ma27 changed the title WIP python3Packages.pyftgl: fix build pythonPackages.pyftgl: fix build Sep 23, 2018
@xeji
Copy link
Contributor

xeji commented Sep 23, 2018

@GrahamcOfBorg build python36Packages.pyftgl python27Packages.pyftgl

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python36Packages.pyftgl, python27Packages.pyftgl

Partial log (click to expand)

writing manifest file 'PyFTGL.egg-info/SOURCES.txt'
running build_ext
copying build/lib.macosx-10.10-x86_64-2.7/FTGL.so ->

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/7mha1imy6p2w6ci4rzyrks8my6dj80r8-python3.6-pyftgl-0.4b
/nix/store/irs6ih0bhhpc3ishgga57k5140h5zqlq-python2.7-pyftgl-0.4b

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.pyftgl, python27Packages.pyftgl

Partial log (click to expand)

copying build/lib.linux-x86_64-3.6/FTGL.cpython-36m-x86_64-linux-gnu.so ->
/nix/store/dlyd8f1r4pdasrsxmx86cgq1gwg1q7kb-python3.6-bootstrapped-pip-18.0/lib/python3.6/site-packages/setuptools/dist.py:398: UserWarning: Normalizing '0.4b' to '0.4b0'
  normalized_version,

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/4bx8wlj0s8l7pg3ybljx3xjpgz0djvk3-python3.6-pyftgl-0.4b
/nix/store/rmqjs95hq8jz6pa51r5jamfp4zzi3w0l-python2.7-pyftgl-0.4b

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.pyftgl, python27Packages.pyftgl

Partial log (click to expand)

copying build/lib.linux-aarch64-3.6/FTGL.cpython-36m-aarch64-linux-gnu.so ->
/nix/store/f7390ycnp6kv1xmrixqf9r1pxq73k4j5-python3.6-bootstrapped-pip-18.0/lib/python3.6/site-packages/setuptools/dist.py:398: UserWarning: Normalizing '0.4b' to '0.4b0'
  normalized_version,

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/9slqvl0l5g1208pfqfbsdnj95wqszn2h-python3.6-pyftgl-0.4b
/nix/store/5zrrw6lvbnrdkr6705znv33xwshg6hdi-python2.7-pyftgl-0.4b

@xeji xeji merged commit 5ad7aed into NixOS:master Sep 23, 2018
xeji pushed a commit that referenced this pull request Sep 23, 2018
@Ma27 @xeji
pythonPackages.pyftgl: fix build (#47232)
c49fa22 
See https://hydra.nixos.org/build/80705583

Recent `boost` versions with `python` enabled have changed their naming
scheme for `boost_python` shared objects which causes issues with the
proper linking when building `pyftgl`.

Previously the library was named `boost_python3`, no it's named
`boost_python36` for current python (3.6.x).

The same issue applies for the `python2`.

Addresses #45960

(cherry picked from commit 5ad7aed)
@xeji
Copy link
Contributor

xeji commented Sep 23, 2018

backported: c49fa22

@Ma27 Ma27 deleted the fix-pyftgl branch September 23, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @xeji @GrahamcOfBorg