release-notes/19.03: add release notes for nix 2.0 requirement bump #47228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
requested review from
samueldr,
GrahamcOfBorg,
srhb and
matthewbauer
Ericson2314
commented
Sep 23, 2018
| @@ -46,7 +46,67 @@ | |||
| xmlns:xlink="http://www.w3.org/1999/xlink" | |||
| xmlns:xi="http://www.w3.org/2001/XInclude" | |||
| version="5.0" | |||
| xml:id="sec-release-19.03-notable-changes"> | |||
There was a problem hiding this comment.
Oops didn't do enough -p
This has been part of every release since 17.03. I think the template for new releases should be updated to contain this.
This is taken from the 18.09 change, which was reverted on release-18.09 but not master. The now-false 18.09 release notes were just removed from master in 29854e2, but since the underlying change is still there, release notes for 19.03 are warranted. This commit takes the now-reverted release notes and reuses them for that.
Ericson2314
force-pushed
the
nix-2.0-19.03
branch
from
5099427
to
1146ae1
Compare
srhb
approved these changes
Sep 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
release-notes: Add missing "Backward Incompatibilities" section
This has been part of every release since 17.03. I think the template
for new releases should be updated to contain this.
release-notes/19.03: add release notes for nix 2.0 requirement bump
This is taken from the 18.09 change, which was reverted on release-18.09 but not master. The now-false 18.09 release notes were just removed from master in 29854e2, but since the underlying change is still there, release notes for 19.03 are warranted. This commit takes the now-reverted release notes and reuses them for that.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)