php: set mysql socket path if mysql[i] or pdo_mysql support is enabled #47227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP tries to discover the mysql default socket path during configure phase by probing the file system: https://github.com/php/php-src/blob/cf3b852109a88a11370d0207cd3b72a53b6a64c3/ext/mysqli/config.m4#L4 This obviously fails to discover /run/mysqld/mysqld.sock, which is being used (hardcoded) across all MySQL flavours. This leads to PHP having no mysql socket path set for the mysql[i] extensions, and `/tmp/mysql.sock` set for pdo_mysql, meaning one currently has to manually configure and set it in php.ini. Luckily, PHP supports setting that path via `--with-mysql-sock=/run/mysqld/mysqld.sock` during configure phase, so let's do this as soon as one of the three modules is enabled. (cherry picked from commit baa04e4)
|
@GrahamcOfBorg test wordpress |
|
Failure on x86_64-darwin (full log) Attempted: php Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: php Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: php Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: tests.wordpress Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: tests.wordpress Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #47220 for 18.03.
As the php expression still uses
composableDerivation, we can't easily query what's enabled while definingconfigureFlags, so simply add thewith-mysql-sockon each enabled feature.PHPs configure phase is happy with that being defined multiple times - not elegant, but I didn't want to resort to bash hackery for that backport :-)
PHP tries to discover the mysql default socket path during configure
phase by probing the file system:
https://github.com/php/php-src/blob/cf3b852109a88a11370d0207cd3b72a53b6a64c3/ext/mysqli/config.m4#L4
This obviously fails to discover /run/mysqld/mysqld.sock, which is being
used (hardcoded) across all MySQL flavours.
This leads to PHP having no mysql socket path set for the mysql[i]
extensions, and
/tmp/mysql.sockset for pdo_mysql,meaning one currently has to manually configure and set it in php.ini.
Luckily, PHP supports setting that path via
--with-mysql-sock=/run/mysqld/mysqld.sockduring configure phase,so let's do this as soon as one of the three modules is enabled.
(cherry picked from commit baa04e4)
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)