Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ycmd for go 1.11 #47254

Merged
merged 1 commit into from Sep 24, 2018
Merged

Update ycmd for go 1.11 #47254

merged 1 commit into from Sep 24, 2018

Conversation

cstrahan
Copy link
Contributor

Motivation for this change

This updates godef and ycmd so that YouCompleteMe can work with Go 1.11 source.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Sep 23, 2018

I guess a back-port does not hurt here.

Mic92
Mic92 reviewed Sep 23, 2018
View reviewed changes
pkgs/development/tools/godef/default.nix Outdated
@@ -2,16 +2,16 @@

buildGoPackage rec {
name = "godef-${version}";
version = "20170920-${stdenv.lib.strings.substring 0 7 rev}";
rev = "b692db1de5229d4248e23c41736b431eb665615d";
version = "20180911-${stdenv.lib.strings.substring 0 7 rev}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the hash from the version number.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I figured I should update that to match contemporary practices. I'll do that when I'm back home.

@cstrahan
Copy link
Contributor Author

Looks like the godef update was already on master (and the version was corrected there as well), so I removed that commit. This should be good to go now, AFAICT.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ycmd

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/5n1b4qc86980wnvin6dkrvy9khqrj65l-ycmd-2018-09-20/lib  /nix/store/5n1b4qc86980wnvin6dkrvy9khqrj65l-ycmd-2018-09-20/bin
patching script interpreter paths in /nix/store/5n1b4qc86980wnvin6dkrvy9khqrj65l-ycmd-2018-09-20
/nix/store/5n1b4qc86980wnvin6dkrvy9khqrj65l-ycmd-2018-09-20/lib/ycmd/third_party/python-future/check_rst.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/5n1b4qc86980wnvin6dkrvy9khqrj65l-ycmd-2018-09-20/lib/ycmd/third_party/bottle/docs/_locale/update.sh: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/5n1b4qc86980wnvin6dkrvy9khqrj65l-ycmd-2018-09-20/lib/ycmd/third_party/bottle/test/travis_setup.sh: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/5n1b4qc86980wnvin6dkrvy9khqrj65l-ycmd-2018-09-20/lib/ycmd/third_party/parso/deploy-master.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/5n1b4qc86980wnvin6dkrvy9khqrj65l-ycmd-2018-09-20/lib/ycmd/third_party/jedi/travis_install.sh: interpreter directive changed from " /usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/5n1b4qc86980wnvin6dkrvy9khqrj65l-ycmd-2018-09-20/lib/ycmd/third_party/jedi/deploy-master.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/5n1b4qc86980wnvin6dkrvy9khqrj65l-ycmd-2018-09-20...
/nix/store/5n1b4qc86980wnvin6dkrvy9khqrj65l-ycmd-2018-09-20

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ycmd

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/c0ihqxhw1z8g3m0p2l0sr2zc72diy4bv-ycmd-2018-09-20/lib  /nix/store/c0ihqxhw1z8g3m0p2l0sr2zc72diy4bv-ycmd-2018-09-20/bin
patching script interpreter paths in /nix/store/c0ihqxhw1z8g3m0p2l0sr2zc72diy4bv-ycmd-2018-09-20
/nix/store/c0ihqxhw1z8g3m0p2l0sr2zc72diy4bv-ycmd-2018-09-20/lib/ycmd/third_party/python-future/check_rst.sh: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/c0ihqxhw1z8g3m0p2l0sr2zc72diy4bv-ycmd-2018-09-20/lib/ycmd/third_party/parso/deploy-master.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/c0ihqxhw1z8g3m0p2l0sr2zc72diy4bv-ycmd-2018-09-20/lib/ycmd/third_party/bottle/test/travis_setup.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/c0ihqxhw1z8g3m0p2l0sr2zc72diy4bv-ycmd-2018-09-20/lib/ycmd/third_party/bottle/docs/_locale/update.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/c0ihqxhw1z8g3m0p2l0sr2zc72diy4bv-ycmd-2018-09-20/lib/ycmd/third_party/jedi/travis_install.sh: interpreter directive changed from " /usr/bin/env bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/c0ihqxhw1z8g3m0p2l0sr2zc72diy4bv-ycmd-2018-09-20/lib/ycmd/third_party/jedi/deploy-master.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/c0ihqxhw1z8g3m0p2l0sr2zc72diy4bv-ycmd-2018-09-20...
/nix/store/c0ihqxhw1z8g3m0p2l0sr2zc72diy4bv-ycmd-2018-09-20

@Mic92 Mic92 merged commit 4a9ca1d into NixOS:master Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cstrahan @Mic92 @GrahamcOfBorg