Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openvpn plugins: use absolute paths to configuration gui #47212

Merged
merged 1 commit into from Sep 23, 2018
Merged

openvpn plugins: use absolute paths to configuration gui #47212

merged 1 commit into from Sep 23, 2018

Conversation

symphorien
Copy link
Member

Motivation for this change

This is based on the suggestion of @jtojnar here #46901 (comment)

This should fix all network manager plugins; I have tested openvpn iodine and vpnc.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

jtojnar
jtojnar reviewed Sep 23, 2018
View reviewed changes
pkgs/tools/networking/network-manager/fortisslvpn/default.nix Outdated
@@ -28,6 +28,7 @@ in stdenv.mkDerivation rec {
"--without-libnm-glib"
"--with-gnome=${if withGnome then "yes" else "no"}"
"--localstatedir=/tmp"
"--enable-absolute-paths=yes"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to specify yes, it is the default for --enable-foo options

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@jtojnar
Copy link
Contributor

jtojnar commented Sep 23, 2018

networkmanager_strongswan seems to use absolute paths by default.

@garbas garbas mentioned this pull request Sep 23, 2018
Closed
9 tasks
@garbas garbas merged commit 5bfe8bf into NixOS:master Sep 23, 2018
@matthewbauer
Copy link
Member

Was this cherry-picked to 18.09?

@jtojnar jtojnar mentioned this pull request Oct 8, 2018
Closed
@prusnak
Copy link
Member

prusnak commented Oct 11, 2018 •
edited

It seems it was not. The basic NetworkManager functionality is broken and it should be backported IMHO.

I created a backport to 18.09 PR here: #48220

@prusnak prusnak mentioned this pull request Oct 11, 2018
Merged
9 tasks
@prusnak
Copy link
Member

prusnak commented Oct 11, 2018

#48220 is merged into release-18.09 now

@symphorien symphorien deleted the nmplugins branch May 18, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@symphorien @jtojnar @matthewbauer @prusnak @garbas @GrahamcOfBorg