Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inkscape, libreoffice-still: fixup to avoid needing to use old poppler #47261

Closed
wants to merge 3 commits into from
Closed

inkscape, libreoffice-still: fixup to avoid needing to use old poppler #47261

wants to merge 3 commits into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 24, 2018

libreoffice-still apparently no longer needs it (probably after big recent update)
and inkscape can use newer poppler with small patch apparently.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: inkscape

The following builds were skipped because they don't evaluate on x86_64-darwin: libreoffice-still

Partial log (click to expand)

                             ^
/tmp/nix-build-inkscape-0.92.3.drv-0/inkscape-0.92.3/src/extension/internal/pdfinput/pdf-parser.cpp:2734:9: error: cannot initialize a variable of type 'char *' with an rvalue of type 'const char *'
  char *name = args[0].getName();
        ^      ~~~~~~~~~~~~~~~~~
5 errors generated.
make[2]: *** [src/CMakeFiles/inkscape_base.dir/build.make:1591: src/CMakeFiles/inkscape_base.dir/extension/internal/pdfinput/pdf-parser.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:700: src/CMakeFiles/inkscape_base.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
builder for '/nix/store/fz2jm18jdiz62fg9iwqhxcar9gc3hav9-inkscape-0.92.3.drv' failed with exit code 2
error: build of '/nix/store/fz2jm18jdiz62fg9iwqhxcar9gc3hav9-inkscape-0.92.3.drv' failed

@dtzWill
Copy link
Member Author

dtzWill commented Sep 24, 2018

Eep, well it worked on Linux. There are other patches that I didn't include for inkscape since they didn't seem needed-- I'll revisit as they touch the files where Darwin has problems.

@dtzWill
Copy link
Member Author

dtzWill commented Sep 24, 2018

Hmm, libreoffice bit is good but inkscape apparently is trickier than originally appeared.

@dtzWill dtzWill closed this Sep 24, 2018
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: inkscape

The following builds were skipped because they don't evaluate on x86_64-darwin: libreoffice-still

Partial log (click to expand)

copying path '/nix/store/i98x1vvd56b1pzpzpzy4g49bd0crpzbd-pangomm-2.40.1-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/gpb3pyyarrx82350qfwmr7knm12ys4y8-gtkmm-2.24.5-dev' from 'https://cache.nixos.org'...
building '/nix/store/m72iqf1fl4n6sdfjy349l0p21mhf2s6l-inkscape-0.92.3.drv'...
/nix/store/ky61xm4xhialdbf2mbjlv8njdcz4x4vh-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/ky61xm4xhialdbf2mbjlv8njdcz4x4vh-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/ky61xm4xhialdbf2mbjlv8njdcz4x4vh-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/ky61xm4xhialdbf2mbjlv8njdcz4x4vh-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: retry: Resource temporarily unavailable
/nix/store/ky61xm4xhialdbf2mbjlv8njdcz4x4vh-cctools-binutils-darwin-wrapper/nix-support/setup-hook: fork: Resource temporarily unavailable
builder for '/nix/store/m72iqf1fl4n6sdfjy349l0p21mhf2s6l-inkscape-0.92.3.drv' failed with exit code 254
error: build of '/nix/store/m72iqf1fl4n6sdfjy349l0p21mhf2s6l-inkscape-0.92.3.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: inkscape, libreoffice-still

Partial log (click to expand)

[ 53%] Building CXX object src/CMakeFiles/inkscape_base.dir/ui/tools/tool-base.cpp.o
[build CXX] vcl/source/window/btndlg.cxx
[build CXX] vcl/source/window/builder.cxx
[ 53%] Building CXX object src/CMakeFiles/inkscape_base.dir/ui/tools/tweak-tool.cpp.o
building of '/nix/store/6lgd6pzd6aaqbpbdj1zrkxjmxrvk9a5y-libreoffice-6.0.6.2.drv' timed out after 3600 seconds
[ 53%] Building CXX object src/CMakeFiles/inkscape_base.dir/ui/tools/zoom-tool.cpp.o
[ 53%] Building CXX object src/CMakeFiles/inkscape_base.dir/ui/dialog/aboutbox.cpp.o
building of '/nix/store/vvgi6cj8bnxkb6gpj3mb9cnd9im8krr7-inkscape-0.92.3.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/03kqj9m6nang82ml053wwcskjns45r7w-libreoffice-6.0.6.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/03kqj9m6nang82ml053wwcskjns45r7w-libreoffice-6.0.6.2.drv', '/nix/store/vvgi6cj8bnxkb6gpj3mb9cnd9im8krr7-inkscape-0.92.3.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: inkscape

The following builds were skipped because they don't evaluate on aarch64-linux: libreoffice-still

Partial log (click to expand)

[ 89%] Building CXX object src/CMakeFiles/inkscape_base.dir/style.cpp.o
[ 89%] Building CXX object src/CMakeFiles/inkscape_base.dir/svg-view-widget.cpp.o
[ 89%] Building CXX object src/CMakeFiles/inkscape_base.dir/style-internal.cpp.o
[ 89%] Building CXX object src/CMakeFiles/inkscape_base.dir/snapper.cpp.o
[ 89%] Building CXX object src/CMakeFiles/inkscape_base.dir/snapped-point.cpp.o
[ 90%] Building CXX object src/CMakeFiles/inkscape_base.dir/svg-view.cpp.o
[ 90%] Building CXX object src/CMakeFiles/inkscape_base.dir/text-editing.cpp.o
[ 90%] Building CXX object src/CMakeFiles/inkscape_base.dir/text-chemistry.cpp.o
building of '/nix/store/lkgvh4xy4yca1y06hjzj5kd8ah1hyl80-inkscape-0.92.3.drv' timed out after 3600 seconds
error: build of '/nix/store/lkgvh4xy4yca1y06hjzj5kd8ah1hyl80-inkscape-0.92.3.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: inkscape, libreoffice-still

Partial log (click to expand)

[build CXX] connectivity/source/drivers/file/FNoException.cxx
[build CXX] connectivity/source/drivers/file/FNumericFunctions.cxx
[build CXX] connectivity/source/drivers/file/FPreparedStatement.cxx
[build CXX] connectivity/source/drivers/file/FResultSet.cxx
[build CXX] connectivity/source/drivers/file/FResultSetMetaData.cxx
[build CXX] connectivity/source/drivers/file/FStatement.cxx
[build CXX] connectivity/source/drivers/file/FStringFunctions.cxx
building of '/nix/store/6lgd6pzd6aaqbpbdj1zrkxjmxrvk9a5y-libreoffice-6.0.6.2.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/03kqj9m6nang82ml053wwcskjns45r7w-libreoffice-6.0.6.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/03kqj9m6nang82ml053wwcskjns45r7w-libreoffice-6.0.6.2.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: inkscape

The following builds were skipped because they don't evaluate on aarch64-linux: libreoffice-still

Partial log (click to expand)

[ 75%] Building CXX object src/CMakeFiles/inkscape_base.dir/widgets/measure-toolbar.cpp.o
[ 75%] Building CXX object src/CMakeFiles/inkscape_base.dir/widgets/mesh-toolbar.cpp.o
[ 75%] Building CXX object src/CMakeFiles/inkscape_base.dir/widgets/lpe-toolbar.cpp.o
[ 75%] Building CXX object src/CMakeFiles/inkscape_base.dir/widgets/pencil-toolbar.cpp.o
[ 76%] Building CXX object src/CMakeFiles/inkscape_base.dir/widgets/node-toolbar.cpp.o
[ 76%] Building CXX object src/CMakeFiles/inkscape_base.dir/widgets/rect-toolbar.cpp.o
[ 76%] Building CXX object src/CMakeFiles/inkscape_base.dir/widgets/spiral-toolbar.cpp.o
[ 76%] Building CXX object src/CMakeFiles/inkscape_base.dir/widgets/spray-toolbar.cpp.o
building of '/nix/store/0kpw4jprbswryq095q8cp4kxfni266ga-inkscape-0.92.3.drv' timed out after 3600 seconds
error: build of '/nix/store/0kpw4jprbswryq095q8cp4kxfni266ga-inkscape-0.92.3.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg