go: Remove pkg/obj directory from the build outputs. #47260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be causing the go package to be roughly 900MB in size.
Mic92
reviewed
Sep 24, 2018
| @@ -178,6 +178,7 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| preFixup = '' | |||
| rm -r $out/share/go/pkg/bootstrap | |||
| rm -r $out/share/go/pkg/obj | |||
There was a problem hiding this comment.
But does not then everybody has to recompile the standardlibary on their own?
There was a problem hiding this comment.
So I'm pretty sure this is the object cache directory - the actual libraries end up in folders called $GOOS_$GOARCH and a tool and include folder. It's also not shipped by go in their download (https://golang.org/dl/). Oddly enough it also doesn't seem to be working since the folder is still present.
There was a problem hiding this comment.
Nevermind - I was confused. The obj folder is correctly deleted and running go install with the modified package doesn't appear to cause any standard library recompilation.
There was a problem hiding this comment.
For reference - the go release tool also deletes this directory.
There was a problem hiding this comment.
I mixed up the prefix, because the static archives where right below this.
|
@GrahamcOfBorg build docker |
|
Failure on x86_64-darwin (full log) Attempted: docker Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: docker Partial log (click to expand)
|
|
backport: 86406e2 |
|
Success on x86_64-linux (full log) Attempted: docker Partial log (click to expand)
|
|
Thanks for merging this :D |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This appears to be causing the go package to be roughly 900MB in size.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)