Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 344e6e229c29
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: a326da978f85
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Sep 23, 2018

  1. php: set mysql socket path if mysql[i] or pdo_mysql support is enabled 

    PHP tries to discover the mysql default socket path during configure
phase by probing the file system:
https://github.com/php/php-src/blob/cf3b852109a88a11370d0207cd3b72a53b6a64c3/ext/mysqli/config.m4#L4

This obviously fails to discover /run/mysqld/mysqld.sock, which is being
used (hardcoded) across all MySQL flavours.

This leads to PHP having no mysql socket path set for the mysql[i]
extensions, and `/tmp/mysql.sock` set for pdo_mysql,
meaning one currently has to manually configure and set it in php.ini.

Luckily, PHP supports setting that path via
`--with-mysql-sock=/run/mysqld/mysqld.sock` during configure phase,
so let's do this as soon as one of the three modules is enabled.
    @flokli
    flokli committed Sep 23, 2018
    Copy the full SHA
    baa04e4 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #47220 from flokli/php-mysql-sock 

    php: set mysql socket path if mysql[i] or pdo_mysql support is enabled
    @Mic92
    Mic92 committed Sep 23, 2018
    Copy the full SHA
    a326da9 View commit details
    Browse the repository at this point in the history