Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coreutils: try 8.30 again, fix bootstrap tools expression motivating revert before #47245

Merged
merged 2 commits into from Sep 25, 2018
Merged

coreutils: try 8.30 again, fix bootstrap tools expression motivating revert before #47245

merged 2 commits into from Sep 25, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 23, 2018

Looks like was a simple small problem, see commit fixing.

cc @vcunat

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
Revert "Revert "Merge NixOS#42880: coreutils: 8.29 -> 8.30""
095ef62 
This reverts commit e3ee9c0.
@dtzWill
make-bootstrap-tools: fix with latest coreutils
4d9f9f1 
Since gcc.lib/lib64 is a symlink to 'lib', the use of
"lib*/libgcc_s.so*" triggered a warning (error) with
the latest coreutils.  Essentially we were doing:

$ cp a/x b/x y/

And latest coreutils rejects such invocations.

Just copy from 'lib', lib64 is a link to it anyway.

* Nothing else in this file bothers looking at lib*
* AFAICT lib* only ever possibly matched lib64 anyway
vcunat
vcunat approved these changes Sep 23, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 😄 (I haven't re-tested anything.)

@xeji xeji merged commit 6aa5f2d into NixOS:staging Sep 25, 2018
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 28, 2018 •
edited

May have led to #51025
Or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @c0bw3b @vcunat @GrahamcOfBorg @xeji