Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quodlibet: add glib-networking dep #47240

Merged
merged 1 commit into from Sep 23, 2018
Merged

quodlibet: add glib-networking dep #47240

merged 1 commit into from Sep 23, 2018

Conversation

joakim1999
Copy link
Contributor

@joakim1999 joakim1999 commented Sep 23, 2018

Added glib-networking as dependency so that quodlibet can securely connect to audio streams. Previously quodlibet would give you an error message when connecting to audio streams that requires secure connection.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Added glib-networking as dependency so that quodlibet can securely connect to audio streams
@jtojnar
Copy link
Contributor

jtojnar commented Sep 23, 2018

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants