-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: Make overrideScope
take arguments in the conventional order for 18.09
#47239
Closed
Ericson2314
wants to merge
1
commit into
NixOS:release-18.09
from
obsidiansystems:overrideScope-order
Closed
lib: Make overrideScope
take arguments in the conventional order for 18.09
#47239
Ericson2314
wants to merge
1
commit into
NixOS:release-18.09
from
obsidiansystems:overrideScope-order
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
6.topic: emacs
Text editor
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: changelog
8.has: documentation
This PR adds or changes documentation
labels
Sep 23, 2018
Ericson2314
changed the title
lib: Make
lib: Make Sep 23, 2018
overrideScope
take arguments in the conventional orderoverrideScope
take arguments in the conventional order for 18.09
grahamc
reviewed
Sep 23, 2018
That <varname>overrideScope</varname> now takes a function with parameters in the opposite order: <literal>self: super: { … }</literal> now whereas it was <literal>super: self: { … }</literal> before. | ||
This brings makes it consistent with everything else related to <literal>super: self: { … }</literal> overrides, including even the other more common implementations of <varname>overrideScope</varname> used in the Haskell infrastructure and other language-specific infrastructures. | ||
The most prominant uses of <varname>makeScope</varname> today include <varname>emacsPackagesNg</varname>, <varname>q5*</varname>, and most desktop enironments' package sets such as <varname>gnome3</varname>, KDE and <varname>plasma5</varname>, <varname>xfce4-13</varname>, and <varname>deepin</varname>. | ||
If you use any of these package sets and experience problems, please check your local configuration for any overrides / overlays and make sure they are now in the conventional <literal>self: super: { … }</literal> form. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- some line-breaks would be nice
- this buries the most important user-facing change under quite a lot of technical bits that aren't relevant to the user trying to fix their system. Ideally we'd swap it: call out exactly who is impacted in the first few words, then how to fix it, then the technical why details.
Yeah, I think it's a good idea to fix the order here! Helps a lot with the docs, too. :) |
GrahamcOfBorg
added
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux
labels
Sep 23, 2018
See the doc changes for details. Since that implementation did not even share any code either until I changed it recently in 3cf4354, this inconsistency is almost certainly an oversight and not intentional. There's no way to make this a smooth transition, sadly, but I hope in listing common uses in the manual, people searching for fixes to their problems will easy find it.
Ericson2314
force-pushed
the
overrideScope-order
branch
from
September 23, 2018 18:31
e95589b
to
658a3b9
Compare
Closing until master PR #47238 is merged to not fracture discussion. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: emacs
Text editor
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: changelog
8.has: documentation
This PR adds or changes documentation
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Backport of #47238.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)