lib: Make overrideScope take arguments in the conventional order for 18.09
#47239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
changed the title
overrideScope take arguments in the conventional orderoverrideScope take arguments in the conventional order for 18.09
grahamc
reviewed
Sep 23, 2018
| That <varname>overrideScope</varname> now takes a function with parameters in the opposite order: <literal>self: super: { … }</literal> now whereas it was <literal>super: self: { … }</literal> before. | ||
| This brings makes it consistent with everything else related to <literal>super: self: { … }</literal> overrides, including even the other more common implementations of <varname>overrideScope</varname> used in the Haskell infrastructure and other language-specific infrastructures. | ||
| The most prominant uses of <varname>makeScope</varname> today include <varname>emacsPackagesNg</varname>, <varname>q5*</varname>, and most desktop enironments' package sets such as <varname>gnome3</varname>, KDE and <varname>plasma5</varname>, <varname>xfce4-13</varname>, and <varname>deepin</varname>. | ||
| If you use any of these package sets and experience problems, please check your local configuration for any overrides / overlays and make sure they are now in the conventional <literal>self: super: { … }</literal> form. |
There was a problem hiding this comment.
- some line-breaks would be nice
- this buries the most important user-facing change under quite a lot of technical bits that aren't relevant to the user trying to fix their system. Ideally we'd swap it: call out exactly who is impacted in the first few words, then how to fix it, then the technical why details.
|
Yeah, I think it's a good idea to fix the order here! Helps a lot with the docs, too. :) |
See the doc changes for details. Since that implementation did not even share any code either until I changed it recently in 3cf4354, this inconsistency is almost certainly an oversight and not intentional. There's no way to make this a smooth transition, sadly, but I hope in listing common uses in the manual, people searching for fixes to their problems will easy find it.
Ericson2314
force-pushed
the
overrideScope-order
branch
from
e95589b
to
658a3b9
Compare
|
Closing until master PR #47238 is merged to not fracture discussion. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Backport of #47238.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)