Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitcoin: don't build things not used, enable parallel building #47258

Merged
merged 3 commits into from Sep 25, 2018
Merged

bitcoin: don't build things not used, enable parallel building #47258

merged 3 commits into from Sep 25, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 24, 2018

This was taking a very long time to build,
the parallel build was the big win probably but
doesn't help building things not used.

Probably not used, anyway?

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: bitcoin

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bitcoin

Partial log (click to expand)

shrinking /nix/store/rhydjs9lm08qks2y2nvxbh8ifwrvpywq-bitcoin-0.16.3/bin/bitcoin-cli
shrinking /nix/store/rhydjs9lm08qks2y2nvxbh8ifwrvpywq-bitcoin-0.16.3/bin/bitcoin-qt
shrinking /nix/store/rhydjs9lm08qks2y2nvxbh8ifwrvpywq-bitcoin-0.16.3/lib/libbitcoinconsensus.so.0.0.0
gzipping man pages under /nix/store/rhydjs9lm08qks2y2nvxbh8ifwrvpywq-bitcoin-0.16.3/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rhydjs9lm08qks2y2nvxbh8ifwrvpywq-bitcoin-0.16.3/lib  /nix/store/rhydjs9lm08qks2y2nvxbh8ifwrvpywq-bitcoin-0.16.3/bin
patching script interpreter paths in /nix/store/rhydjs9lm08qks2y2nvxbh8ifwrvpywq-bitcoin-0.16.3
checking for references to /build in /nix/store/rhydjs9lm08qks2y2nvxbh8ifwrvpywq-bitcoin-0.16.3...
postPatchMkspecs
/nix/store/rhydjs9lm08qks2y2nvxbh8ifwrvpywq-bitcoin-0.16.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bitcoin

Partial log (click to expand)

shrinking /nix/store/z992xm0942x6vkq87592bb12wzkm7l93-bitcoin-0.16.3/bin/bitcoin-cli
shrinking /nix/store/z992xm0942x6vkq87592bb12wzkm7l93-bitcoin-0.16.3/bin/bitcoind
shrinking /nix/store/z992xm0942x6vkq87592bb12wzkm7l93-bitcoin-0.16.3/lib/libbitcoinconsensus.so.0.0.0
gzipping man pages under /nix/store/z992xm0942x6vkq87592bb12wzkm7l93-bitcoin-0.16.3/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z992xm0942x6vkq87592bb12wzkm7l93-bitcoin-0.16.3/lib  /nix/store/z992xm0942x6vkq87592bb12wzkm7l93-bitcoin-0.16.3/bin
patching script interpreter paths in /nix/store/z992xm0942x6vkq87592bb12wzkm7l93-bitcoin-0.16.3
checking for references to /build in /nix/store/z992xm0942x6vkq87592bb12wzkm7l93-bitcoin-0.16.3...
postPatchMkspecs
/nix/store/z992xm0942x6vkq87592bb12wzkm7l93-bitcoin-0.16.3

matthewbauer
matthewbauer reviewed Sep 24, 2018
View reviewed changes
pkgs/applications/altcoins/bitcoin.nix Outdated
configureFlags = [ "--with-boost-libdir=${boost.out}/lib" ]
configureFlags = [ "--with-boost-libdir=${boost.out}/lib"
"--disable-bench"
"--disable-tests"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make this conditional on doCheck

@dtzWill
Copy link
Member Author

dtzWill commented Sep 25, 2018

Good call, thanks!

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: bitcoin

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bitcoin

Partial log (click to expand)

shrinking /nix/store/z992xm0942x6vkq87592bb12wzkm7l93-bitcoin-0.16.3/bin/bitcoin-cli
shrinking /nix/store/z992xm0942x6vkq87592bb12wzkm7l93-bitcoin-0.16.3/bin/bitcoind
shrinking /nix/store/z992xm0942x6vkq87592bb12wzkm7l93-bitcoin-0.16.3/lib/libbitcoinconsensus.so.0.0.0
gzipping man pages under /nix/store/z992xm0942x6vkq87592bb12wzkm7l93-bitcoin-0.16.3/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z992xm0942x6vkq87592bb12wzkm7l93-bitcoin-0.16.3/lib  /nix/store/z992xm0942x6vkq87592bb12wzkm7l93-bitcoin-0.16.3/bin
patching script interpreter paths in /nix/store/z992xm0942x6vkq87592bb12wzkm7l93-bitcoin-0.16.3
checking for references to /build in /nix/store/z992xm0942x6vkq87592bb12wzkm7l93-bitcoin-0.16.3...
postPatchMkspecs
/nix/store/z992xm0942x6vkq87592bb12wzkm7l93-bitcoin-0.16.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bitcoin

Partial log (click to expand)

shrinking /nix/store/rhydjs9lm08qks2y2nvxbh8ifwrvpywq-bitcoin-0.16.3/bin/bitcoind
shrinking /nix/store/rhydjs9lm08qks2y2nvxbh8ifwrvpywq-bitcoin-0.16.3/bin/bitcoin-qt
shrinking /nix/store/rhydjs9lm08qks2y2nvxbh8ifwrvpywq-bitcoin-0.16.3/bin/bitcoin-tx
gzipping man pages under /nix/store/rhydjs9lm08qks2y2nvxbh8ifwrvpywq-bitcoin-0.16.3/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rhydjs9lm08qks2y2nvxbh8ifwrvpywq-bitcoin-0.16.3/lib  /nix/store/rhydjs9lm08qks2y2nvxbh8ifwrvpywq-bitcoin-0.16.3/bin
patching script interpreter paths in /nix/store/rhydjs9lm08qks2y2nvxbh8ifwrvpywq-bitcoin-0.16.3
checking for references to /build in /nix/store/rhydjs9lm08qks2y2nvxbh8ifwrvpywq-bitcoin-0.16.3...
postPatchMkspecs
/nix/store/rhydjs9lm08qks2y2nvxbh8ifwrvpywq-bitcoin-0.16.3

@dtzWill dtzWill merged commit c82ac80 into NixOS:master Sep 25, 2018
@dtzWill dtzWill deleted the fix/bitcoin-long-compile branch September 25, 2018 07:47
@roconnor roconnor mentioned this pull request Oct 4, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @matthewbauer