Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Build solaar with pythonPackages #46150

Merged
merged 1 commit into from Sep 8, 2018
Merged

Fix: Build solaar with pythonPackages #46150

merged 1 commit into from Sep 8, 2018

Conversation

ysndr
Copy link
Member

@ysndr ysndr commented Sep 6, 2018

Motivation for this change

Python34Packags led into build errors with pytest when trying to install solaar, changing to pythonPackages solved this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@samueldr
Copy link
Member

samueldr commented Sep 8, 2018

Merging, then cherry-picking for #45960 thanks!

(I'm a solaar user, just upgrading, and you did the hard work, thanks!)

@samueldr samueldr merged commit ca80826 into NixOS:master Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ysndr @samueldr @GrahamcOfBorg