Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust-bindgen: 0.37.0 -> 0.40.0 #46137

Merged
merged 1 commit into from Sep 28, 2018
Merged

rust-bindgen: 0.37.0 -> 0.40.0 #46137

merged 1 commit into from Sep 28, 2018

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Sep 6, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @Ralith

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rust-bindgen

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/w46l5j4wfpqp9x17ri69wk1dqpc2pqjx-rust-bindgen-0.40.0
shrinking /nix/store/w46l5j4wfpqp9x17ri69wk1dqpc2pqjx-rust-bindgen-0.40.0/bin/.bindgen-wrapped
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/w46l5j4wfpqp9x17ri69wk1dqpc2pqjx-rust-bindgen-0.40.0/bin
patching script interpreter paths in /nix/store/w46l5j4wfpqp9x17ri69wk1dqpc2pqjx-rust-bindgen-0.40.0
/nix/store/w46l5j4wfpqp9x17ri69wk1dqpc2pqjx-rust-bindgen-0.40.0/bin/bindgen: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/w46l5j4wfpqp9x17ri69wk1dqpc2pqjx-rust-bindgen-0.40.0...
/nix/store/w46l5j4wfpqp9x17ri69wk1dqpc2pqjx-rust-bindgen-0.40.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: rust-bindgen

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/16xk8micnkwnw1gn8n402n81y577qaf8-rust-bindgen-0.40.0
shrinking /nix/store/16xk8micnkwnw1gn8n402n81y577qaf8-rust-bindgen-0.40.0/bin/.bindgen-wrapped
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/16xk8micnkwnw1gn8n402n81y577qaf8-rust-bindgen-0.40.0/bin
patching script interpreter paths in /nix/store/16xk8micnkwnw1gn8n402n81y577qaf8-rust-bindgen-0.40.0
/nix/store/16xk8micnkwnw1gn8n402n81y577qaf8-rust-bindgen-0.40.0/bin/bindgen: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/16xk8micnkwnw1gn8n402n81y577qaf8-rust-bindgen-0.40.0...
/nix/store/16xk8micnkwnw1gn8n402n81y577qaf8-rust-bindgen-0.40.0

Ralith
Ralith approved these changes Sep 6, 2018
View reviewed changes
Copy link
Contributor

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@xeji xeji merged commit 6c90a97 into NixOS:master Sep 28, 2018
@dywedir dywedir deleted the rust-bindgen branch September 28, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dywedir @GrahamcOfBorg @Ralith @xeji