Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teamspeak_server: 3.0.13.6->3.3.0 #46134

Closed
wants to merge 1 commit into from

Conversation

cleverca22
Copy link
Contributor

Motivation for this change

the new teamspeak client refuses to connect to the old server

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: teamspeak_server

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: teamspeak_server

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: teamspeak_server

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@Mic92
Copy link
Member

Mic92 commented Sep 6, 2018

Should this be backported to 18.09 as well? I suppose the current version would be not to useful for people otherwise?

@samueldr
Copy link
Member

samueldr commented Sep 6, 2018

I suppose it should be backported. This is like the inverse of the "Spotify situation", where a service (though not centralized here) needs to be updated to stay compatible with the clients.

The client, too, will probably need an update. It's currently a tiny bit behind.

@cleverca22
Copy link
Contributor Author

i can confirm that the 3.1.10 client works on the 3.3.0 server, but it would be nice to also upgrade the client, since it asks about installing the update on every launch, and obviously wont work on nixos

@Mic92
Copy link
Member

Mic92 commented Sep 6, 2018

I think for teamspeak we can backport all updates. We do the same for other proprietary software.

@Mic92
Copy link
Member

Mic92 commented Sep 6, 2018

Can you update the client as well so both are in sync?

@cleverca22
Copy link
Contributor Author

closing due to conflicts with #50327 and my PR now being a downgrade

@cleverca22 cleverca22 closed this Nov 21, 2018
@cleverca22 cleverca22 deleted the teamspeak-bump branch November 21, 2018 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants