Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.nipype: Futures is python 2 only. Also fix building. #46125

Merged
merged 1 commit into from Sep 6, 2018
Merged

python.pkgs.nipype: Futures is python 2 only. Also fix building. #46125

merged 1 commit into from Sep 6, 2018

Conversation

ashgillman
Copy link
Contributor

Motivation for this change

It seems like this commit: ac21188 may have broken nipype for Python 3.

@FRidh I'm not sure why the rm pytest.ini command was added, but that file seemed not to exist. There is a nipype/pytest.ini file, but removing it led to testing errors.

Things done

Tested build for python 2 and 3.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Sep 5, 2018

@GrahamcOfBorg build python.pkgs.nipype python3.pkgs.nipype

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python.pkgs.nipype, python3.pkgs.nipype

Partial log (click to expand)

    warn('NO FSL found')

workflows/dmri/fsl/tbss.py::nipype.workflows.dmri.fsl.tbss.create_tbss_2_reg
  /build/nipype-1.1.2/nipype/workflows/dmri/fsl/tbss.py:143: UserWarning: NO FSL found
    warn('NO FSL found')

-- Docs: https://docs.pytest.org/en/latest/warnings.html
====== 2732 passed, 233 skipped, 7 xfailed, 21 warnings in 160.41 seconds ======
/nix/store/8gcwflrvpsyvb5y5wrzrqkq1dwdvy01b-python2.7-nipype-1.1.2
/nix/store/gmpswgsg8kljc7z0phhzk209586g8yqy-python3.6-nipype-1.1.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python.pkgs.nipype, python3.pkgs.nipype

Partial log (click to expand)

    warn('NO FSL found')

workflows/dmri/fsl/artifacts.py::nipype.workflows.dmri.fsl.artifacts.all_fmb_pipeline
  /build/nipype-1.1.2/nipype/interfaces/fsl/preprocess.py:1887: UserWarning: This has not been fully tested. Please report any failures.
    warn('This has not been fully tested. Please report any failures.')

-- Docs: https://docs.pytest.org/en/latest/warnings.html
===== 2732 passed, 233 skipped, 7 xfailed, 20 warnings in 1420.94 seconds ======
/nix/store/5daf1mdmgp8gdsvw3pmagqq9rz01z9mm-python2.7-nipype-1.1.2
/nix/store/aa344sb04hxfv0xqmphi2nlhnvy1p2jd-python3.6-nipype-1.1.2

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python.pkgs.nipype, python3.pkgs.nipype

Partial log (click to expand)


----------------------------------------------------------------------
Ran 9 tests in 0.758s

FAILED (errors=6)
Test failed: <unittest.runner.TextTestResult run=9 errors=6 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=9 errors=6 failures=0>
builder for '/nix/store/1s6lghb4dgfplnc6fd2yr7ql6bjdh3y8-python3.6-xvfbwrapper-0.2.9.drv' failed with exit code 1
cannot build derivation '/nix/store/6igway5pnda4dv1a31gq5yyyq6n08f1f-python3.6-nipype-1.1.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/4v9nv86znkyv9pc8i10a8w8i2kk72gk3-python2.7-nipype-1.1.2.drv', '/nix/store/6igway5pnda4dv1a31gq5yyyq6n08f1f-python3.6-nipype-1.1.2.drv' failed

@FRidh
Copy link
Member

FRidh commented Sep 6, 2018

@ashgillman possible because it wanted to do some checks we're not interested in.

@Mic92 Mic92 merged commit df2cc41 into NixOS:master Sep 6, 2018
@ashgillman ashgillman deleted the nipype-futures-py2-only branch September 6, 2018 09:15
@ashgillman
Copy link
Contributor Author

Thanks

@Mic92
Copy link
Member

Mic92 commented Sep 6, 2018

backport:

[detached HEAD cec33e2] python.pkgs.nipype: Futures is python 2 only. Also fix building.
Author: Ashley Gillman gillmanash@gmail.com
Date: Wed Sep 5 12:37:28 2018 +0100
1 file changed, 4 insertions(+), 4 deletions(-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ashgillman @Mic92 @GrahamcOfBorg @FRidh