Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

top-level: Deprecate top-level {build,host,target}Platform for 18.09 #46146

Merged
merged 1 commit into from Sep 6, 2018
Merged

top-level: Deprecate top-level {build,host,target}Platform for 18.09 #46146

merged 1 commit into from Sep 6, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Backport of #46059.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ericson2314
top-level: Deprecate top-level {build,host,target}Platform
e51f736 
I don't know when we can/should remove them, but this at least gets
people to stop using them. The preferred alternatives also date back to
17.09 so writing forward-compatable code without extra conditions is
easy.

Beginning with these as they are the least controversial.
@Ericson2314 Ericson2314 merged commit 5e3f2d4 into NixOS:release-18.09 Sep 6, 2018
@Ericson2314 Ericson2314 deleted the deprecate-top-level-platform-aliases branch September 6, 2018 12:11
This was referenced Sep 6, 2018
Merged
Closed
@srhb
Copy link
Contributor

srhb commented Sep 7, 2018

This breaks the build of nixpkgs.tarball from release-combined: https://hydra.nixos.org/build/81003452

@srhb
Copy link
Contributor

srhb commented Sep 7, 2018

It's also very confusing to casual users. 😆

❯ nix-env -u
trace: WARNING: top-level `buildPlatform` is deprecated since 18.09. Please use `stdenv.buildPlatform`.
trace: WARNING: top-level `hostPlatform` is deprecated since 18.09. Please use `stdenv.hostPlatform`.
trace: WARNING: top-level `targetPlatform` is deprecated since 18.09. Please use `stdenv.targetPlatform`.

@Ericson2314
Copy link
Member Author

Thanks and sorry. I'll move them so callPackage can provide them but they aren't at the top level of nix-env and the tarball job to trip on.

@Ericson2314 Ericson2314 mentioned this pull request Sep 7, 2018
Merged
9 tasks
@infinisil infinisil mentioned this pull request Sep 10, 2018
Closed
@srhb srhb mentioned this pull request Sep 11, 2018
Merged
9 tasks
@vcunat
Copy link
Member

vcunat commented Sep 12, 2018 •
edited

@Ericson2314: no updates how the blocker might get resolved, even temporarily? (or someone else)

@Ericson2314
Copy link
Member Author

I merged #46517. There's nothing trivial in my head and I need to look at the deprecation RFC and implementation more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ericson2314 @srhb @vcunat @GrahamcOfBorg