Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile2graph: init at 2018-01-03 #46136

Merged
merged 1 commit into from Sep 18, 2018
Merged

Conversation

CMCDragonkai
Copy link
Member

Motivation for this change

This adds makefile2graph, the ability to generate graphs from makefiles!

While doing this, I found the tests doesn't work properly because of a bunch of assumptions, so I didn't run them. It would require substitutions on the source first.

Furthermore I found that replace substitution make was conflicting on substitutions on make2graph. So I separated them into 1 substitution, and the other was a wrapProgram. Any advice on simplifying this?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@CMCDragonkai
Copy link
Member Author

Anybody?

@CMCDragonkai
Copy link
Member Author

I'd like to get this merged. I wonder if there's any issues holding this up.

@orivej-nixos orivej-nixos merged commit 9f3c27a into NixOS:master Sep 18, 2018
@CMCDragonkai CMCDragonkai deleted the makefile2graph branch September 19, 2018 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants