Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc-*: Clean up crossStageStatic logic #46127

Merged
merged 1 commit into from Sep 25, 2018
Merged

gcc-*: Clean up crossStageStatic logic #46127

merged 1 commit into from Sep 25, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

54282b9 tread carefuly to avoid a mass rebuild. This embraces the mass rebuild to clean things up.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

CC @oxij

@oxij
Copy link
Member

oxij commented Sep 5, 2018

if "$crossStageStatic" == 1; then

That's an illegal syntax, you need either test, or [.

@Ericson2314
gcc-*: Clean up crossStageStatic logic
d68a9d9 
54282b9 tread carefuly to avoid a mass
rebuild. This embraces the mass rebuild to clean things up.
@oxij oxij mentioned this pull request Sep 23, 2018
Merged
3 tasks
@Ericson2314 Ericson2314 merged commit b1d5182 into NixOS:staging Sep 25, 2018
@Ericson2314 Ericson2314 deleted the gcc-crossStageStatic-cleanup branch September 25, 2018 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @oxij @GrahamcOfBorg